Skip to content

feat(synthetics): add Playwright 5.1 and 6.0 runtimes - #37665

Merged
mergify[bot] merged 6 commits into
aws:mainfrom
yatakemi:synthetics-runtime-playwright-5_1-and-6
Apr 30, 2026
Merged

feat(synthetics): add Playwright 5.1 and 6.0 runtimes#37665
mergify[bot] merged 6 commits into
aws:mainfrom
yatakemi:synthetics-runtime-playwright-5_1-and-6

Conversation

@yatakemi

@yatakemi yatakemi commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue # (if applicable)

None

Reason for this change

AWS Synthetics Canary now supports for new runtime.

Description of changes

Add new runtimes

  • Playwright 5.1
  • Playwright 6.0

Describe any new or updated permissions being added

None

Description of how you validated changes

The documentation was reviewed and the code was checked to be consistent with pre-existing enum values.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 22, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team April 22, 2026 13:26
@github-actions github-actions Bot added the p2 label Apr 22, 2026
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 22, 2026
View reviewed changes

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@yatakemi

yatakemi commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Exemption Request

This PR adds a single static runtime constant that mirrors AWS's official syn-nodejs-playwright-5.1 and syn-nodejs-playwright-6.0 runtime.

Justification:

  • No README needed: The runtime is self-documented via JSDoc with a link to AWS docs
  • No unit test needed: It's a static readonly constant matching AWS's runtime string exactly
  • No integration test needed: The runtime is already supported and tested by AWS; we're exposing the constant CDK users can already use via RuntimeFamily.NODEJS with a manual version string

This follows the same pattern as all other runtime constants in the file (e.g., SYNTHETICS_NODEJS_PLAYWRIGHT_5_0).

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 22, 2026
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 22, 2026
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 23, 2026
@aws-cdk-automation
aws-cdk-automation dismissed their stale review April 30, 2026 10:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

leonmk-aws
leonmk-aws previously approved these changes Apr 30, 2026
View reviewed changes
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify

mergify Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-04-30 10:11 UTC · Rule: default-squash
  • 🚫 Left the queue — 2026-04-30 11:12 UTC · at 8530416e753893b9d943152f3a26a8311ab11304

This pull request spent 1 hour 21 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/agent-docs-sync-reminder.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 30, 2026
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
mergify Bot dismissed leonmk-aws’s stale review April 30, 2026 13:38

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 30, 2026
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify

mergify Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-04-30 14:59 UTC · Rule: default-squash
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-04-30 15:00 UTC · at bedecbc633554e4da9585e08b6df3703fc588d50 · squash

This pull request spent 16 seconds in the queue, including 3 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit c1afb43 into aws:main Apr 30, 2026
20 of 21 checks passed
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 30, 2026

This branch was previously deployed

1 inactive deployment
automation — bedecbc6 Deployed Apr 30, 2026 by aws-cdk-automation via validate-pr #343147
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leonmk-aws leonmk-aws leonmk-aws approved these changes
@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments
+1 more reviewer
@badmintoncryer badmintoncryer badmintoncryer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leonmk-aws leonmk-aws

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yatakemi @aws-cdk-automation @badmintoncryer @leonmk-aws