feat: Add MegaLinter plugin - #476
Merged
Merged
Conversation
mjpieters
force-pushed
the
megalinter
branch
2 times, most recently
from
March 28, 2022 10:19
eeb3be3 to
1ecec83
Compare
Contributor
Author
|
NOTE: The README and the quickstart documentation are both linking to a non-existing 0.32.0 path; they basically will be broken until you release a new version. Feel free to replace these with |
Contributor
Author
|
If this were to land I'll send the MegaLinter a PR to include the plugin in their documentation. |
mjpieters
force-pushed
the
megalinter
branch
2 times, most recently
from
March 28, 2022 12:13
4bfc2d6 to
5bab015
Compare
Pull Request Test Coverage Report for Build 2059812961
💛 - Coveralls |
andreoliwa
force-pushed
the
megalinter
branch
2 times, most recently
from
March 28, 2022 22:32
f7506bc to
dc3a276
Compare
andreoliwa
reviewed
Mar 28, 2022
mjpieters
force-pushed
the
megalinter
branch
2 times, most recently
from
March 29, 2022 16:12
3758459 to
aad9f6e
Compare
This makes it possible to run nitpick as a [MegaLinter](https://megalinter.github.io/) step.
Contributor
Author
|
Mea Culpa, I noticed I had not uppercased the linter name, now remedied. Here is a demo using and with a local change, reducing and finally, with |
andreoliwa
approved these changes
Mar 31, 2022
andreoliwa
left a comment
andreoliwa
left a comment
Owner
There was a problem hiding this comment.
Great addition, thanks for adding Nitpick to MegaLinter.
Now it worked here (after uppercasing NITPICK on ENABLE_LINTERS):
❌ Linted [NITPICK] files with [nitpick]: Found 1 error(s) - (0.85s)
[Text Reporter] Generated TEXT report: /tmp/lint/report/linters_logs/ERROR-NITPICK.log
+----SUMMARY-+---------+---------+-------+-------+--------+--------------+
| Descriptor | Linter | Mode | Files | Fixed | Errors | Elapsed time |
+------------+---------+---------+-------+-------+--------+--------------+
| ❌ NITPICK | nitpick | project | n/a | yes | 1 | 0.85s |
+------------+---------+---------+-------+-------+--------+--------------+
and
✅ Linted [NITPICK] files with [nitpick] successfully - (0.77s)
[Text Reporter] Generated TEXT report: /tmp/lint/report/linters_logs/SUCCESS-NITPICK.log
+----SUMMARY-+---------+---------+-------+-------+--------+--------------+
| Descriptor | Linter | Mode | Files | Fixed | Errors | Elapsed time |
+------------+---------+---------+-------+-------+--------+--------------+
| ✅ NITPICK | nitpick | project | n/a | yes | 0 | 0.77s |
+------------+---------+---------+-------+-------+--------+--------------+
and finally, with
APPLY_FIXES=alladded, again eliding output for brevity:
Yep, I was using it. 👍🏻
|
That's great, I'll add it to MegaLinter plugins page :) ( or you can add it if you feel i'm too slow ^^ ) https://megalinter.github.io/latest/plugins/#plugins-catalog |
This was referenced Mar 24, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
# [0.33.0](v0.32.0...v0.33.0) (2023-03-27) ### Bug Fixes * actually show chosen styles in log output ([#477](#477)) ([9a685ac](9a685ac)) * **deps:** update dependency attrs to v22 ([d3ad0e0](d3ad0e0)) * **deps:** update dependency click to v8.1.3 ([bd54df5](bd54df5)) * **deps:** update dependency configupdater to v3.1.1 ([024fd16](024fd16)) * **deps:** update dependency dpath to v2.1.5 ([#557](#557)) ([6a4fddd](6a4fddd)) * **deps:** update dependency flake8 to v5 ([#559](#559)) ([1bc7b06](1bc7b06)) * **deps:** update dependency freezegun to v1.2.2 ([#543](#543)) ([9a67f5a](9a67f5a)) * **deps:** update dependency identify to v2.5.22 ([00dbdce](00dbdce)) * **deps:** update dependency importlib-resources to v5.12.0 ([68aae5c](68aae5c)) * **deps:** update dependency jmespath to v1 ([e51c957](e51c957)) * **deps:** update dependency marshmallow to v3.19.0 ([a314480](a314480)) * **deps:** update dependency marshmallow-polyfield to v5.11 ([#545](#545)) ([b05092b](b05092b)) * **deps:** update dependency more-itertools to v8.14.0 ([#531](#531)) ([139ef6b](139ef6b)) * **deps:** update dependency pytest to v7 ([a080454](a080454)) * **deps:** update dependency pytest-cov to v4 ([db278d4](db278d4)) * **deps:** update dependency pytest-datadir to v1.4.1 ([c6d5cb4](c6d5cb4)) * **deps:** update dependency pytest-socket to v0.6.0 ([#534](#534)) ([2bdf0d6](2bdf0d6)) * **deps:** update dependency pytest-testmon to v1.4.5 ([392fce5](392fce5)) * **deps:** update dependency pytest-testmon to v2.0.1 ([81b300d](81b300d)) * **deps:** update dependency pytest-testmon to v2.0.2 ([1e58ff2](1e58ff2)) * **deps:** update dependency python-slugify to v8 ([77649bd](77649bd)) * **deps:** update dependency requests to v2.28.2 ([#536](#536)) ([0af1b14](0af1b14)) * **deps:** update dependency requests-cache to v0.9.8 ([#518](#518)) ([2135344](2135344)) * **deps:** update dependency requests-cache to v1.0.1 ([2104255](2104255)) * **deps:** update dependency responses to v0.23.1 ([#537](#537)) ([796034c](796034c)) * **deps:** update dependency sphinx to v4.5.0 ([#538](#538)) ([aee2267](aee2267)) * **deps:** update dependency sphinx to v5 ([#560](#560)) ([b7fcb67](b7fcb67)) * **deps:** update dependency sphinx_rtd_theme to v1.2.0 ([f729818](f729818)) * **deps:** update dependency sphobjinv to v2.3.1 ([33bea38](33bea38)) * **deps:** update dependency strenum to v0.4.10 ([4aed308](4aed308)) * **deps:** update dependency testfixtures to v6.18.5 ([311a5ca](311a5ca)) * **deps:** update dependency tomlkit to v0.11.6 ([a28e6d7](a28e6d7)) * document.add does not work on Linux ([#487](#487)) ([07048bb](07048bb)) * further improve file path handling ([#479](#479)) ([6cff555](6cff555)) * pass in token to fetch GH default branch ([#475](#475)) ([46ea598](46ea598)) ### Features * add MegaLinter plugin ([#476](#476)) ([212a36a](212a36a)) * add Python 3.11 ([2a7cbea](2a7cbea))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to run nitpick as a MegaLinter step.
This installs a specific version of nitpick, so you can, in future, link to a
particular release and know it'll remain stable.
Checklist
makelocally before pushing commitsflake8plugin (normal mode)flake8plugin (offline mode)