Skip to content

fix: upgrade @actions/core to avoid deprecation warnings - #208

Merged
amannn merged 1 commit into
amannn:mainfrom
tisonkun:upgrade-actions-core
Oct 17, 2022
Merged

amannn merged 1 commit into
amannn:mainfrom
tisonkun:upgrade-actions-core

Conversation

@tisonkun

Copy link
Copy Markdown
Contributor

@amannn

amannn commented Oct 14, 2022

Copy link
Copy Markdown
Owner

Hi and thank you for your PR!

Can you please have a look at the contributors guide to make sure your PR covers the relevant steps?

@tisonkun
tisonkun force-pushed the upgrade-actions-core branch from 57e7d51 to b4d61c7 Compare October 14, 2022 10:50
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tisonkun force-pushed the upgrade-actions-core branch from b4d61c7 to 4a876fb Compare October 14, 2022 10:51
@tisonkun

Copy link
Copy Markdown
Contributor Author

@amannn updated and here is the PR on the forked repo: tisonkun#1

@tisonkun

Copy link
Copy Markdown
Contributor Author

Shall we change the dist linter base branch to "main"?

          if [ $(git diff origin/master --name-only -- 'dist/**' | wc -l) -gt 0 ]
          then
            echo "Please do not update 'dist/'. CI will update it automatically on merge."
            exit 1
          fi

@amannn

amannn commented Oct 14, 2022

Copy link
Copy Markdown
Owner

Shall we change the dist linter base branch to "main"?

Oh that would be nice, thank you!

@tisonkun

Copy link
Copy Markdown
Contributor Author

Oh that would be nice, thank you!

So here's the PR: #209

Let me know if there's further work I should do to proceed with these two PRs.

@amannn amannn left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@amannn
amannn merged commit 91f4126 into amannn:main Oct 17, 2022
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 5.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tisonkun added a commit to tisonkun/pulsar that referenced this pull request Oct 17, 2022
nodece pushed a commit to apache/pulsar that referenced this pull request Oct 18, 2022
* [fix][ci] Fix deprecation warnings about set-output

Upstream fix: amannn/action-semantic-pull-request#208

* Update .github/workflows/ci-semantic-pull-request.yml
@tisonkun
tisonkun deleted the upgrade-actions-core branch November 17, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants