Repository navigation
Optimize API calls - #1033
Merged
Merged
Optimize API calls#1033
Conversation
dsame
force-pushed
the
apirate
branch
2 times, most recently
from
June 22, 2023 11:49
3e8b587 to
41108c8
Compare
dsame
force-pushed
the
apirate
branch
2 times, most recently
from
June 22, 2023 12:25
c988721 to
6afea3f
Compare
dsame
force-pushed
the
apirate
branch
15 times, most recently
from
June 25, 2023 13:56
46a9b53 to
6148637
Compare
IvanZosimov
reviewed
Jul 4, 2023
nikolai-laevskii
suggested changes
Jul 5, 2023
nikolai-laevskii
left a comment
nikolai-laevskii
left a comment
Contributor
There was a problem hiding this comment.
It seems to be working as it should so far. And the rest of the code seems ok stylewise.
dsame
force-pushed
the
apirate
branch
3 times, most recently
from
July 5, 2023 09:29
46bef01 to
333a692
Compare
nikolai-laevskii
approved these changes
Jul 5, 2023
dusan-trickovic
approved these changes
Jul 5, 2023
dusan-trickovic
left a comment
dusan-trickovic
left a comment
Contributor
There was a problem hiding this comment.
Everything looks alright to me :) Tested a workflow run using this branch and everything works error-free. The comments I left below are just nitpicks and can be ignored, as there are no problems present. Thank you!
2 of 5 tasks
msorens
reviewed
Jul 13, 2023
Comment on lines
+32
to
+33
| unprocessed issue skipping the issues proceeded during the previous run(s). The state is reset when all the issues are | ||
| proceeded. This should be considered for scheduling workflow runs. |
There was a problem hiding this comment.
Typos in the readme:
s/proceeded/processed/g
Closed
6 tasks done
Merged
11 tasks
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Each next run should not proceed the issues proceed during the previous run. In the other case running from the very beginning never reach the issues beyond API limit.
Changes:
persist,rehydrateandresetmethodImplementation details:
Related issue:
link to the related issue.
Check list: