Add support for closure as argument to default - #380
Merged
Merged
Conversation
cyqsimon
commented
Sep 24, 2025
cyqsimon
commented
Sep 24, 2025
Contributor
Author
|
Seems like I forgot to attach span info somewhere... |
TedDriggs
requested changes
Sep 24, 2025
TedDriggs
left a comment
TedDriggs
left a comment
Owner
There was a problem hiding this comment.
This is directionally excellent - requested changes are small.
Please rebase before next push, as I've fixed an issue upstream with how Callable handles literals.
- E.g. `#[darling(default = || get_val())]` - See TedDriggs#219 (comment)
cyqsimon
force-pushed
the
default-closure
branch
from
September 24, 2025 13:18
b1612a9 to
5011902
Compare
Contributor
Author
|
I did an interactive rebase to keep the history clean. Hope you find this okay. Will work on those compile tests next. |
Tested cases: - Callable has wrong return type - Callable's return type is the pre-mapped type - Field is multi-occurence but callable's return type isn't - Callable has extraneous parameters (expecting 0) - Quoted closure is incorrectly allowed All cases (excepted for quoted closure) test all three accepted forms (path expr, path literal, closure expr)
cyqsimon
force-pushed
the
default-closure
branch
from
September 24, 2025 15:08
5011902 to
e5fb5af
Compare
TedDriggs
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #376
#[darling(default = || get_val())]