Add PreservedStrExpr utility wrapper - #346
Merged
Merged
Conversation
Owner
|
This is very elegant. |
m4tx
added a commit
to cot-rs/cot
that referenced
this pull request
Jul 10, 2025
Our contribution has just been released, so keeping `PreservedStrExpr` is no longer needed (TedDriggs/darling#346).
seqre
pushed a commit
to cot-rs/cot
that referenced
this pull request
Jul 10, 2025
Our contribution has just been released, so keeping `PreservedStrExpr` is no longer needed (TedDriggs/darling#346).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
darlingevaluates the expression inside string literals. This can be worked around withpreserve_str_literal, but sometimes it's difficult—for instance, when a struct containsHashMap<syn::Ident, syn::Expr>.This commit introduces a utility wrapper over
syn::Exprthat has a simpleFromMetaimpl that just copies the innerExprinstance. It can be then used like so: