fix type import check for default-import/re-export in js files - #57778
Merged
Andrew Branch (andrewbranch) merged 1 commit intoMar 27, 2024
Merged
Andrew Branch (andrewbranch) merged 1 commit into
Andrew Branch (andrewbranch) merged 1 commit into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and
Isabel Duan (iisaduan)
March 27, 2024 20:59
Andrew Branch (andrewbranch)
approved these changes
Mar 27, 2024
Isabel Duan (iisaduan)
approved these changes
Mar 27, 2024
Member
|
Thanks Lyu, Wei-Da (@jasonlyu123)! |
Member
|
TypeScript Bot (@typescript-bot) cherry-pick to release-5.4 |
Contributor
TypeScript Bot (typescript-bot)
pushed a commit
that referenced
this pull request
Apr 8, 2024
Contributor
|
Hey, Andrew Branch (@andrewbranch)! I've created #58116 for you. |
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Apr 8, 2024
…e-5.4 (#58116) Co-authored-by: Lyu, Wei-Da <36730922+jasonlyu123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57740. Pretty much copied from
shouldIncludeSymbol.getCombinedLocalAndExportSymbolFlagsfor the default export andskipAliasforexport { someFunciton }andexport { someFunction } from './module'.