Skip to content

feat: ObjectComponent serialization - #1293

Merged
jpenilla merged 2 commits into
PaperMC:unstable/4from
Emilxyz:feat/object-component-serializers
Sep 24, 2025
Merged

jpenilla merged 2 commits into
PaperMC:unstable/4from
Emilxyz:feat/object-component-serializers

Conversation

@Emilxyz

@Emilxyz Emilxyz commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Adds serialization support for the new ObjectComponent in:

  • api - ComponentFlattener
  • serializer-configurate4
  • text-serializer-gson

@jpenilla
jpenilla requested a review from kezz August 22, 2025 20:09
@Emilxyz
Emilxyz marked this pull request as draft August 26, 2025 15:15
@Emilxyz
Emilxyz force-pushed the feat/object-component-serializers branch 4 times, most recently from 95c6bcf to 9f5d2c7 Compare August 28, 2025 15:38
@Emilxyz

Emilxyz commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

Updated for 25w35a.
I'll keep this as draft for now, probably until there's a pre release or release candidate even. I don't think it makes much sense to review it before that when mojang could be introducing changes again with the next snapshot

If anyone wants to leave feedback anyway, feel free!

@Emilxyz
Emilxyz force-pushed the feat/object-component-serializers branch from 2a34785 to c6975fe Compare September 1, 2025 08:26
@Emilxyz
Emilxyz force-pushed the feat/object-component-serializers branch from c6975fe to 73aff23 Compare September 19, 2025 16:41
@Emilxyz
Emilxyz marked this pull request as ready for review September 19, 2025 16:47
@kezz kezz added this to the 4.25.0 milestone Sep 23, 2025

@kezz kezz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't reviewed the configurate changes but json and flattener changes lgtm!

e.g., `{"player":false}` would be considered a "valid" profile before this
@Emilxyz
Emilxyz force-pushed the feat/object-component-serializers branch from 73aff23 to bce65f1 Compare September 24, 2025 06:06
@jpenilla
jpenilla merged commit 228a027 into PaperMC:unstable/4 Sep 24, 2025
3 checks passed
@Emilxyz
Emilxyz deleted the feat/object-component-serializers branch September 25, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants