Repository navigation
Upgrade TypeScript to 4.8 for most packages - #23730
Merged
Merged
Conversation
Jeff Fisher (xirzec)
requested review from
Florian Born (FlorianBorn71),
Harsha Nalluru (HarshaNalluru),
Jackson Weber (JacksonWeber),
KarishmaGhiya,
Ben Broderick Phillips (benbp),
Brian Terlson (bterlson),
Albert Cheng (ckairen),
Craig Treasure (craigktreasure),
Deyaa (deyaaeldeen),
Hector Hernandez (hectorhdzg),
Jeremy Meng (jeremymeng),
Jose Manuel Heredia Hidalgo (joheredi),
Mike Harder (mikeharder),
Praveen Kuttappan (praveenkuttappan),
Sarangan Rajamanickam (sarangan12),
Timo van Veenendaal (timovv),
Liangying.Wei (vicancy),
Wes Haggard (weshaggard) and
Will Temple (witemple-msft)
as code owners
November 5, 2022 00:06
ghost
added
Digital Twins
Event Grid
Event Hubs
Azure.Identity
KeyVault
Service Bus
Storage
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
|
build storm! Looks good. We also need to update codegen to use the new version |
Deyaa (deyaaeldeen)
approved these changes
Nov 5, 2022
Deyaa (deyaaeldeen)
left a comment
Deyaa (deyaaeldeen)
left a comment
Member
There was a problem hiding this comment.
TA, SR, and EH changes in particular look good. I skimmed the rest, and they seem fine too. Thanks for upgrading us 😄
Member
Author
ask and ye shall receive: Azure/autorest.typescript#1657 |
Member
Author
|
Purview appears to be a long-standing set of failures. Filed #23731 |
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades TS for many packages, but only a few actually needed minor code changes in order to build cleanly.