Skip to content

Commit 9ccaacb

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Fix format errors in nova security group rule list"
2 parents b7f673c + ada9d35 commit 9ccaacb

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

‎openstackclient/compute/v2/security_group.py‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,23 @@
3131
def _xform_security_group_rule(sgroup):
3232
info = {}
3333
info.update(sgroup)
34-
info.update(
35-
{'port_range': "%u:%u" % (
36-
info.pop('from_port'),
37-
info.pop('to_port'),
38-
)}
39-
)
40-
info['ip_range'] = info['ip_range']['cidr']
34+
from_port = info.pop('from_port')
35+
to_port = info.pop('to_port')
36+
if isinstance(from_port, int) and isinstance(to_port, int):
37+
port_range = {'port_range': "%u:%u" % (from_port, to_port)}
38+
elif from_port is None and to_port is None:
39+
port_range = {'port_range': ""}
40+
else:
41+
port_range = {'port_range': "%s:%s" % (from_port, to_port)}
42+
info.update(port_range)
43+
if 'cidr' in info['ip_range']:
44+
info['ip_range'] = info['ip_range']['cidr']
45+
else:
46+
info['ip_range'] = ''
4147
if info['ip_protocol'] == 'icmp':
4248
info['port_range'] = ''
49+
elif info['ip_protocol'] is None:
50+
info['ip_protocol'] = ''
4351
return info
4452

4553

0 commit comments

Comments
 (0)