Skip to content

Commit 7e49444

Browse files
wolphwolph
committed
ci: absorb experimental-env timeouts at the job level
A job that hits timeout-minutes is cancelled rather than failed, which the step-level continue-on-error cannot absorb. The experimental docs-linkcheck env did exactly that while waiting on slow external servers and marked the whole run cancelled.
1 parent 2c66e91 commit 7e49444

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎.github/workflows/main.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ jobs:
3636
name: tox (${{ matrix.tox-env }})
3737
runs-on: ubuntu-latest
3838
timeout-minutes: 10
39+
# Job-level continue-on-error, not only step-level: a job that hits
40+
# timeout-minutes is cancelled rather than failed, which a step-level
41+
# continue-on-error cannot absorb -- an experimental env (e.g.
42+
# docs-linkcheck waiting on slow external servers) would still mark
43+
# the whole run cancelled.
44+
continue-on-error: ${{ matrix.experimental || false }}
3945
strategy:
4046
fail-fast: false
4147
matrix:

0 commit comments

Comments
 (0)