Skip to content

Using vuex with the latest version of vue has a broken hot reload test #2241

Description

@alecgibson

Version

4.1.0

Describe the bug

When developing with a fork of vuex, I noticed that vuex tests break when bumping vue to the latest version:

 FAIL  test/unit/hot-reload.spec.js
  ● Hot Reload › getters

    expect(received).toBe(expected) // Object.is equality

    Expected: 10
    Received: 1

      279 |     })
      280 |
    > 281 |     expect(vm.a).toBe(10)
          |                  ^
      282 |     store.dispatch('check', 10)
      283 |
      284 |     if (isSSR) {

      at Object.toBe (test/unit/hot-reload.spec.js:281:18)

Reproduction

  1. Check out vuejs/vuex main branch
  2. Run yarn test
  3. Tests pass
  4. Update vue: yarn add --dev vue@latest
  5. Run yarn test again
  6. Tests fail

Expected behavior

Tests pass on latest version of vue — presumably this means there's broken behaviour when using vuex with the latest version of vue?

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions