Skip to content

fix(plugin-vue): respect hmr: false server config - #2797

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
haoqunjiang:fix-hmr-false
Mar 31, 2021
Merged

patak-cat merged 1 commit into
vitejs:mainfrom
haoqunjiang:fix-hmr-false

Conversation

@haoqunjiang

Copy link
Copy Markdown
Member

Description

Fixes #2790

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat
patak-cat requested a review from Shinigami92 March 31, 2021 06:48
@patak-cat patak-cat added feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) plugin: vue labels Mar 31, 2021
@patak-cat
patak-cat merged commit 27e0c3f into vitejs:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plugin-vue] should not inject HMR code if the server is started with hmr: false

3 participants