Commit 2333769
committed
Fix vpk-deployment split fallout: dotnet-coverage, GitHub list staleness
- Restore the dotnet-coverage install in the vpk job: RunCoveredDotnet
shells out to that CLI, so moving it to vpk-deployment broke MsiTests
on Windows.
- WaitForReleaseCountAsync now also waits until every listed release
shows at least one asset (a fresh GitHub listing can briefly return a
published release with an empty asset list) and allows 120s: the split
job makes all three legs hit GitHub simultaneously, which worsened
list-after-write lag (empty draft listings, 'No assets found' on
download round-trip).
- Retry GithubSourceLive rows up to 3 times: a row's fresh API calls can
hit a stale replica even after the shared context confirmed the feed
('asset not found in any release' / 404 from correct clients).1 parent b0d21e0 commit 2333769
3 files changed
Lines changed: 23 additions & 6 deletions
File tree
- .github/workflows
- test/Velopack.Deployment.Tests
- Infra
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
151 | 154 | | |
152 | 155 | | |
153 | 156 | | |
| |||
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
252 | | - | |
253 | | - | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
254 | 256 | | |
255 | 257 | | |
256 | 258 | | |
257 | | - | |
| 259 | + | |
258 | 260 | | |
259 | | - | |
| 261 | + | |
260 | 262 | | |
261 | 263 | | |
262 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
348 | | - | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
349 | 361 | | |
350 | 362 | | |
351 | 363 | | |
| |||
0 commit comments