Skip to content

Commit cff2b50

Browse files
sroettgerV8 LUCI CQ
sroettger
authored and
V8 LUCI CQ
committed
Deprecate signature checks in Set{Accessor,NativeDataProperty}
Change from V8_DEPRECATE_SOON to V8_DEPRECATED. It turned out that we don't have to make changes in chrome code, so we can go to deprecated right away. Bug: chromium:1310790 Change-Id: I1bd529536d3a0098f11f13b3e44fe3dbc80eed04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571897 Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#79811}
1 parent c35ca2b commit cff2b50

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎include/v8-template.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,15 @@ class V8_EXPORT Template : public Data {
8989
* defined by FunctionTemplate::HasInstance()), an implicit TypeError is
9090
* thrown and no callback is invoked.
9191
*/
92-
V8_DEPRECATE_SOON("Do signature check in accessor")
92+
V8_DEPRECATED("Do signature check in accessor")
9393
void SetNativeDataProperty(
9494
Local<String> name, AccessorGetterCallback getter,
9595
AccessorSetterCallback setter, Local<Value> data,
9696
PropertyAttribute attribute, Local<AccessorSignature> signature,
9797
AccessControl settings = DEFAULT,
9898
SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
9999
SideEffectType setter_side_effect_type = SideEffectType::kHasSideEffect);
100-
V8_DEPRECATE_SOON("Do signature check in accessor")
100+
V8_DEPRECATED("Do signature check in accessor")
101101
void SetNativeDataProperty(
102102
Local<Name> name, AccessorNameGetterCallback getter,
103103
AccessorNameSetterCallback setter, Local<Value> data,
@@ -827,14 +827,14 @@ class V8_EXPORT ObjectTemplate : public Template {
827827
* defined by FunctionTemplate::HasInstance()), an implicit TypeError is
828828
* thrown and no callback is invoked.
829829
*/
830-
V8_DEPRECATE_SOON("Do signature check in accessor")
830+
V8_DEPRECATED("Do signature check in accessor")
831831
void SetAccessor(
832832
Local<String> name, AccessorGetterCallback getter,
833833
AccessorSetterCallback setter, Local<Value> data, AccessControl settings,
834834
PropertyAttribute attribute, Local<AccessorSignature> signature,
835835
SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
836836
SideEffectType setter_side_effect_type = SideEffectType::kHasSideEffect);
837-
V8_DEPRECATE_SOON("Do signature check in accessor")
837+
V8_DEPRECATED("Do signature check in accessor")
838838
void SetAccessor(
839839
Local<Name> name, AccessorNameGetterCallback getter,
840840
AccessorNameSetterCallback setter, Local<Value> data,

0 commit comments

Comments
 (0)