Skip to content

Commit 0cd67eb

Browse files
caitpCommit Bot
caitp
authored and
Commit Bot
committed
[esnext] ship "hashbang" syntax
Turns --harmony-hashbang on by default. Intent to ship: https://groups.google.com/d/msg/v8-dev/hlCVa_XZ3TM/UWjjyOq3FwAJ ChromeStatus page: https://www.chromestatus.com/feature/5134505706782720 BUG=v8:8523 R=gsathya@chromium.org, mathias@chromium.org, adamk@chromium.org Change-Id: I821f69e45eb0a63a3f49181e2b88b0bcd091af2c Reviewed-on: https://chromium-review.googlesource.com/c/1486113 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#59847}
1 parent 5c4dd9f commit 0cd67eb

2 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎src/flag-definitions.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,8 @@ DEFINE_IMPLICATION(harmony_private_methods, harmony_private_fields)
213213
#endif
214214

215215
// Features that are complete (but still behind --harmony/es-staging flag).
216-
#define HARMONY_STAGED_BASE(V) \
217-
V(harmony_numeric_separator, "harmony numeric separator between digits") \
218-
V(harmony_hashbang, "harmony hashbang syntax")
216+
#define HARMONY_STAGED_BASE(V) \
217+
V(harmony_numeric_separator, "harmony numeric separator between digits")
219218

220219
#ifdef V8_INTL_SUPPORT
221220
#define HARMONY_STAGED(V) \
@@ -239,7 +238,8 @@ DEFINE_IMPLICATION(harmony_private_methods, harmony_private_fields)
239238
V(harmony_string_matchall, "harmony String.prototype.matchAll") \
240239
V(harmony_object_from_entries, "harmony Object.fromEntries()") \
241240
V(harmony_await_optimization, "harmony await taking 1 tick") \
242-
V(harmony_private_fields, "harmony private fields in class literals")
241+
V(harmony_private_fields, "harmony private fields in class literals") \
242+
V(harmony_hashbang, "harmony hashbang syntax")
243243

244244
#ifdef V8_INTL_SUPPORT
245245
#define HARMONY_SHIPPING(V) \

‎test/test262/test262.status‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -555,29 +555,29 @@
555555
'language/expressions/prefix-increment/eval-nostrict': [SKIP],
556556

557557
# https://bugs.chromium.org/p/v8/issues/detail?id=8850
558-
'language/comments/hashbang/escaped-bang-041': [FAIL],
559-
'language/comments/hashbang/escaped-bang-u0021': [FAIL],
560-
'language/comments/hashbang/escaped-bang-u21': [FAIL],
561-
'language/comments/hashbang/escaped-bang-x21': [FAIL],
562-
'language/comments/hashbang/escaped-hash-043': [FAIL],
563-
'language/comments/hashbang/escaped-hash-u0023': [FAIL],
564-
'language/comments/hashbang/escaped-hash-u23': [FAIL],
565-
'language/comments/hashbang/escaped-hash-x23': [FAIL],
566-
'language/comments/hashbang/escaped-hashbang': [FAIL],
567-
'language/comments/hashbang/eval': [FAIL],
568-
'language/comments/hashbang/eval-indirect': [FAIL],
569-
'language/comments/hashbang/module': [FAIL],
570-
'language/comments/hashbang/multi-line-comment': [FAIL],
571-
'language/comments/hashbang/no-line-separator': [FAIL],
572-
'language/comments/hashbang/not-empty': [FAIL],
573-
'language/comments/hashbang/preceding-directive-prologue': [FAIL],
574-
'language/comments/hashbang/preceding-directive-prologue-sc': [FAIL],
575-
'language/comments/hashbang/preceding-empty-statement': [FAIL],
576-
'language/comments/hashbang/preceding-hashbang': [FAIL],
577-
'language/comments/hashbang/preceding-line-comment': [FAIL],
578-
'language/comments/hashbang/preceding-multi-line-comment': [FAIL],
579-
'language/comments/hashbang/preceding-whitespace': [FAIL],
580-
'language/comments/hashbang/use-strict': [FAIL],
558+
'language/comments/hashbang/escaped-bang-041': [SKIP],
559+
'language/comments/hashbang/escaped-bang-u0021': [SKIP],
560+
'language/comments/hashbang/escaped-bang-u21': [SKIP],
561+
'language/comments/hashbang/escaped-bang-x21': [SKIP],
562+
'language/comments/hashbang/escaped-hash-043': [SKIP],
563+
'language/comments/hashbang/escaped-hash-u0023': [SKIP],
564+
'language/comments/hashbang/escaped-hash-u23': [SKIP],
565+
'language/comments/hashbang/escaped-hash-x23': [SKIP],
566+
'language/comments/hashbang/escaped-hashbang': [SKIP],
567+
'language/comments/hashbang/eval': [SKIP],
568+
'language/comments/hashbang/eval-indirect': [SKIP],
569+
'language/comments/hashbang/module': [SKIP],
570+
'language/comments/hashbang/multi-line-comment': [SKIP],
571+
'language/comments/hashbang/no-line-separator': [SKIP],
572+
'language/comments/hashbang/not-empty': [SKIP],
573+
'language/comments/hashbang/preceding-directive-prologue': [SKIP],
574+
'language/comments/hashbang/preceding-directive-prologue-sc': [SKIP],
575+
'language/comments/hashbang/preceding-empty-statement': [SKIP],
576+
'language/comments/hashbang/preceding-hashbang': [SKIP],
577+
'language/comments/hashbang/preceding-line-comment': [SKIP],
578+
'language/comments/hashbang/preceding-multi-line-comment': [SKIP],
579+
'language/comments/hashbang/preceding-whitespace': [SKIP],
580+
'language/comments/hashbang/use-strict': [SKIP],
581581

582582
######################## NEEDS INVESTIGATION ###########################
583583

0 commit comments

Comments
 (0)