Skip to content

Commit 6254ea9

Browse files
authored
Prevent duplicate listeners and memory leak (maybe-finance#387)
* Prevent duplicate listeners and memory leak Signed-off-by: Konnor Rogers <konnor5456@gmail.com> * Update dropdown_controller.js Signed-off-by: Konnor Rogers <konnor5456@gmail.com> --------- Signed-off-by: Konnor Rogers <konnor5456@gmail.com>
1 parent be79430 commit 6254ea9

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎app/javascript/controllers/dropdown_controller.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ export default class extends Controller {
99
this.menuTarget.classList.toggle("hidden");
1010
}
1111

12-
hideMenu() {
12+
hideMenu = () => {
1313
this.menuTarget.classList.add("hidden");
1414
}
1515

1616
connect() {
17-
document.addEventListener("click", () => this.hideMenu());
17+
document.addEventListener("click", this.hideMenu);
1818
}
1919

2020
disconnect() {
21-
document.removeEventListener("click", () => this.hideMenu());
21+
document.removeEventListener("click", this.hideMenu);
2222
}
23-
}
23+
}

0 commit comments

Comments
 (0)