Alias 'to throw' as 'to throw ... satisfying'

No description provided.

Aliases for "to throw" are already supported - see the documentation for the assertion here.

The word "satisfying" is not something defined for "to throw", but if we added it that wouldn't really be an alias but an entirely different assertion. However, you can already achieve exactly the semantics you want by using expect.it, for example:

expect(() => { throw new Error() }, 'to throw', expect.it('to have property', 'message'));
expect(() => { throw new Error() }, 'to throw error', expect.it('to have property', 'message'));
expect(() => { throw new Error() }, 'to throw exception', expect.it('to have property', 'message'));

The to throw... assertion already uses "to satisfy" semantics, though? In the light of that I think it would make sense to add the ...satisfying variant as an alias?

My apologies, I think I misread the value type to mean it wouldn't compare the error using satisfy semantics - the assertion does something a little special for strings I believe (comparing the message against it) hence the expect.it suggestion.

The issue title was also a bit confusing, I've updated it to make it a bit clearer. While I have your attention, what does <function> to throw (a|an) <function> do :)?

unexpected/lib/assertions.js

Lines 1030 to 1044 in 9b30831

    
           expect.addAssertion( 
        
             '<function> to throw (a|an) <function>', 
        
             (expect, subject, value) => { 
        
               const constructorName = utils.getFunctionName(value); 
        
               if (constructorName) { 
        
                 expect.argsOutput[0] = output => { 
        
                   output.jsFunctionName(constructorName); 
        
                 }; 
        
               } 
        
               expect.errorMode = 'nested'; 
        
               return expect(subject, 'to throw').then(error => { 
        
                 expect(error, 'to be a', value); 
        
               }); 
        
             } 
        
           );

@joelmukuthu

I've been thinking about this some more - I can definitely see the value in this alias but I'd like to raise one concern.

Using satisfying here would introduce something that behaves a little differently than for example "to have an item satisfying" primarily because of the matching of the error message to a string of its supplied. That would make this use of "satisfying" a little different to all the others. My concern is also that since (unfortunately) strings can be thrown at the language level this would create an annoying ambibugity. I might be over losing this though so keen to hear thoughts.

@joelmukuthu thanks for expanding on the description a bit :)

@alexjeffburke

@alexjeffburke I agree, but I've also always thought of to satisfy as an assertion that allows you to assert against different types which to me makes this an acceptable ambiguity aka "it's a feature" :D. Actually I think to throw error satisfying <string> reads better than to throw error <string>

I agree about to throw error satisfying <string> reading better. And to throw error satisfying <object> even more so!

<function> to throw (a|an) <function> checks that the thrown value is an instance of a particular class, eg.:

expect(myFunction, 'to throw an', httpErrors.Conflict);

Agreed about that spelling for which I think means we've reached some broad agreement - I can have a look next time I'm near core.

Fix special casing of UnexpectedError in <function> to error/throw

the assertion does something a little special for strings I believe (comparing the message against it)

You're right, that's a bit of a wart in itself, but I think we can fix that so it reduces directly to <UnexpectedError> to satisfy...: #538.

Fix special casing of UnexpectedError in <function> to error/throw

@joelmukuthu

@joelmukuthu, personally I'd welcome a PR for this now that the other oddity got resolved.

Navigation Menu

Repository navigation

Alias 'to throw' as 'to throw ... satisfying' #535

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	expect.addAssertion(
	'<function> to throw (a\|an) <function>',
	(expect, subject, value) => {
	const constructorName = utils.getFunctionName(value);
	if (constructorName) {
	expect.argsOutput[0] = output => {
	output.jsFunctionName(constructorName);
	};
	}
	expect.errorMode = 'nested';
	return expect(subject, 'to throw').then(error => {
	expect(error, 'to be a', value);
	});
	}
	);

Alias 'to throw' as 'to throw ... satisfying' #535

Description

Activity

alexjeffburke commented on Dec 2, 2018

papandreou commented on Dec 3, 2018

alexjeffburke commented on Dec 3, 2018

joelmukuthu commented on Dec 3, 2018

alexjeffburke commented on Dec 4, 2018

joelmukuthu commented on Dec 4, 2018

papandreou commented on Dec 4, 2018

alexjeffburke commented on Dec 4, 2018

papandreou commented on Dec 9, 2018

papandreou commented on Jan 3, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions