mock-fs 4.3.0 broken on node 8 #208

Activity

1. AGrzes commented on Jun 5, 2017

   

   AGrzes

   on Jun 5, 2017

   Last edited by AGrzes

   ContributorAuthor

   More actions

   It looks like node 8 is throwing away the values provided to callback by mock-fs.

   // Special case of `makeCallback()` that is specific to async `*stat()` calls as
   // an optimization, since the data passed back to the callback needs to be
   // transformed anyway.
   function makeStatsCallback(cb) {
     if (cb === undefined) {
       return rethrow();
     }
   
     if (typeof cb !== 'function') {
       throw new TypeError('"callback" argument must be a function');
     }
   
     return function(err) {
       if (err) return cb(err);
       cb(err, statsFromValues());
     };
   }
   

   https://github.com/nodejs/node/blob/v8.0.0/lib/fs.js#L139-L155
2. AGrzes commented on Jun 5, 2017

   

   AGrzes

   on Jun 5, 2017

   ContributorAuthor

   More actions

   Related issue #197 and PR nodejs/node#11665
3. AGrzes commented on Jun 5, 2017

   

   AGrzes

   on Jun 5, 2017

   ContributorAuthor

   More actions

   Started work in #209
4. tschaub commented on Jun 11, 2017

   

   tschaub

   on Jun 11, 2017

   Owner

   More actions

   Fix published in mock-fs@4.4. Thanks @AGrzes.
5. tschaub

   closed this as completedon Jun 11, 2017