Skip to content

Unhandled RecoverStakeError paths in Nominator Pool V2 can deadlock round rotation and permanently freeze nominator funds. #24

Description

@neodix42

When Elector returns RecoverStakeError, Proxy.tolk may fail to forward the error (fee mode/value mismatch), and Pool.tolk also has an effectively empty RecoverStakeError handling path that does not clean validator round state. As a result, RoundData.users can remain non-empty indefinitely, causing round rotation logic to keep the pool closed and preventing round advancement, new stakes, and processing of pending withdrawals/deposits, leading to permanent fund lockup conditions.

The issue is not considered practical because it works as intended: RecoverStakeError intentionally does not modify the state, so its potential non-delivery is not an issue. A failed stake withdrawal does not remove the stake record.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions