Skip to content

Commit 7d807a8

Browse files
authored
INotebookEditor need not inherit IInteractiveBase (microsoft#13145)
1 parent b334417 commit 7d807a8

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎src/client/datascience/types.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ export interface INotebookEditorProvider {
557557

558558
// For native editing, the INotebookEditor acts like a TextEditor and a TextDocument together
559559
export const INotebookEditor = Symbol('INotebookEditor');
560-
export interface INotebookEditor extends IInteractiveBase {
560+
export interface INotebookEditor extends Disposable {
561561
/**
562562
* Type of editor, whether it is the old, custom or native notebook editor.
563563
* Once VSC Notebook is stable, this property can be removed.
@@ -580,10 +580,17 @@ export interface INotebookEditor extends IInteractiveBase {
580580
readonly visible: boolean;
581581
readonly active: boolean;
582582
readonly model: INotebookModel;
583+
onExecutedCode: Event<string>;
584+
notebook?: INotebook;
583585
show(): Promise<void>;
584586
runAllCells(): void;
585587
runSelectedCell(): void;
586588
addCellBelow(): void;
589+
undoCells(): void;
590+
redoCells(): void;
591+
removeAllCells(): void;
592+
interruptKernel(): Promise<void>;
593+
restartKernel(): Promise<void>;
587594
}
588595

589596
export const IInteractiveWindowListener = Symbol('IInteractiveWindowListener');

0 commit comments

Comments
 (0)