Skip to content

Edit file panel - some HTML & layout issues #1908

Description

@phiw13

1/ some fields are missing their <label for=> tags: “name”, “existing file”, ”download count”

2/ the “missing” file panel, incorrect layout for the “Existing file” field, the surrounding <div>s are missing

Expected:

<div class="txp-form-field exist-file-name"> 
  <div class="txp-form-field-label"><label for="file-existing">Existing file</label></div>
  <div class="txp-form-field-value">
    <select name="filename" id="file-existing">
      <option value="" selected="selected">&nbsp;</option>
      <option value="darkness_v2.pdf" dir="auto">darkness_v2.pdf</option>
    </select>
  </div>
</div>

Or does this widget need its own form (as was the case with TXP 4.8.8) ? Then it might be better placed next/after the Upload/assign file form at the top?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions