@@ -12606,7 +12606,7 @@ void MessagesManager::init() {
1260612606 } else if (begins_with(log_string, " local message ")) {
1260712607 log_string.remove_prefix(15);
1260812608 } else {
12609- LOG(ERROR) << "Message id expected, found " << log_string;
12609+ LOG(ERROR) << "Message identifier expected, found " << log_string;
1261012610 continue;
1261112611 }
1261212612
@@ -13512,7 +13512,7 @@ std::pair<DialogId, unique_ptr<MessagesManager::Message>> MessagesManager::creat
1351213512 message->contains_mention || dialog_type == DialogType::User);
1351313513
1351413514 if (content_type == MessageContentType::ExpiredPhoto || content_type == MessageContentType::ExpiredVideo) {
13515- CHECK(message->ttl == 0); // ttl is ignored/set to 0 if the message has already been expired
13515+ CHECK(message->ttl == 0); // TTL is ignored/set to 0 if the message has already been expired
1351613516 if (message->reply_markup != nullptr) {
1351713517 if (message->reply_markup->type != ReplyMarkup::Type::InlineKeyboard) {
1351813518 message->had_reply_markup = true;
@@ -13527,7 +13527,7 @@ std::pair<DialogId, unique_ptr<MessagesManager::Message>> MessagesManager::creat
1352713527
1352813528 if (message_info.media_album_id != 0) {
1352913529 if (!is_allowed_media_group_content(content_type)) {
13530- LOG(ERROR) << "Receive media group id " << message_info.media_album_id << " in " << message_id << " from "
13530+ LOG(ERROR) << "Receive media group identifier " << message_info.media_album_id << " in " << message_id << " from "
1353113531 << dialog_id << " with content "
1353213532 << oneline(to_string(
1353313533 get_message_content_object(message->content.get(), td_, message->date, is_content_secret)));
@@ -13616,14 +13616,14 @@ FullMessageId MessagesManager::on_get_message(MessageInfo &&message_info, bool f
1361613616 if (message_id <= d->last_new_message_id) {
1361713617 if (get_message_force(d, message_id, "receive missed unsent message not from update") != nullptr) {
1361813618 LOG(ERROR) << "New " << old_message_id << "/" << message_id << " in " << dialog_id << " from " << source
13619- << " has id less than last_new_message_id = " << d->last_new_message_id;
13619+ << " has identifier less than last_new_message_id = " << d->last_new_message_id;
1362013620 return FullMessageId();
1362113621 }
1362213622 // if there is no message yet, then it is likely was missed because of a server bug and is being repaired via
1362313623 // get_message_from_server from after_get_difference
1362413624 // TODO move to INFO
1362513625 LOG(ERROR) << "Receive " << old_message_id << "/" << message_id << " in " << dialog_id << " from " << source
13626- << " with id less than last_new_message_id = " << d->last_new_message_id
13626+ << " with identifier less than last_new_message_id = " << d->last_new_message_id
1362713627 << " and trying to add it anyway";
1362813628 } else {
1362913629 LOG(ERROR) << "Ignore " << old_message_id << "/" << message_id << " received not through update from " << source
@@ -14880,8 +14880,8 @@ void MessagesManager::fix_dialog_last_notification_id(Dialog *d, bool from_menti
1488014880 CHECK(!message_id.is_scheduled());
1488114881 MessagesConstIterator it(d, message_id);
1488214882 auto &group_info = from_mentions ? d->mention_notification_group : d->message_notification_group;
14883- VLOG(notifications) << "Trying to fix last notification id in " << group_info.group_id << " from " << d->dialog_id
14884- << " from " << message_id << "/" << group_info.last_notification_id;
14883+ VLOG(notifications) << "Trying to fix last notification identifier in " << group_info.group_id << " from "
14884+ << d->dialog_id << " from " << message_id << "/" << group_info.last_notification_id;
1488514885 if (*it != nullptr && ((*it)->message_id == message_id || (*it)->have_next)) {
1488614886 while (*it != nullptr) {
1488714887 const Message *m = *it;
@@ -25849,7 +25849,8 @@ unique_ptr<MessagesManager::MessageForwardInfo> MessagesManager::get_message_for
2584925849 if (forward_header->from_id_ != nullptr) {
2585025850 sender_dialog_id = DialogId(forward_header->from_id_);
2585125851 if (!sender_dialog_id.is_valid()) {
25852- LOG(ERROR) << "Receive invalid sender id in message forward header: " << oneline(to_string(forward_header));
25852+ LOG(ERROR) << "Receive invalid sender identifier in message forward header: "
25853+ << oneline(to_string(forward_header));
2585325854 sender_dialog_id = DialogId();
2585425855 }
2585525856 }
@@ -27247,7 +27248,7 @@ MessagesManager::MessageNotificationGroup MessagesManager::get_message_notificat
2724727248 if (last_notification_date != group_info.last_notification_date ||
2724827249 last_notification_id != group_info.last_notification_id) {
2724927250 LOG(ERROR) << "Fix last notification date in " << d->dialog_id << " from " << group_info.last_notification_date
27250- << " to " << last_notification_date << " and last notification id from "
27251+ << " to " << last_notification_date << " and last notification identifier from "
2725127252 << group_info.last_notification_id << " to " << last_notification_id;
2725227253 set_dialog_last_notification(d->dialog_id, group_info, last_notification_date, last_notification_id,
2725327254 "get_message_notification_group_force");
@@ -27354,24 +27355,24 @@ vector<Notification> MessagesManager::get_message_notifications_from_database_fo
2735427355
2735527356 auto notification_id = m->notification_id.is_valid() ? m->notification_id : m->removed_notification_id;
2735627357 if (!notification_id.is_valid()) {
27357- VLOG(ERROR) << "Can't find notification ID for " << m->message_id << " in " << d->dialog_id;
27358+ VLOG(ERROR) << "Can't find notification identifier for " << m->message_id << " in " << d->dialog_id;
2735827359 continue;
2735927360 }
2736027361 CHECK(m->message_id.is_valid());
2736127362
2736227363 bool is_correct = true;
2736327364 if (notification_id.get() >= from_notification_id.get()) {
2736427365 // possible if two messages has the same notification_id
27365- LOG(ERROR) << "Have nonmonotoic notification ids : " << d->dialog_id << " " << m->message_id << " "
27366+ LOG(ERROR) << "Have nonmonotonic notification identifiers : " << d->dialog_id << " " << m->message_id << " "
2736627367 << notification_id << " " << from_message_id << " " << from_notification_id;
2736727368 is_correct = false;
2736827369 } else {
2736927370 from_notification_id = notification_id;
2737027371 is_found = true;
2737127372 }
2737227373 if (m->message_id >= from_message_id) {
27373- LOG(ERROR) << "Have nonmonotoic message ids : " << d->dialog_id << " " << m->message_id << " " << notification_id
27374- << " " << from_message_id << " " << from_notification_id;
27374+ LOG(ERROR) << "Have nonmonotonic message identifiers : " << d->dialog_id << " " << m->message_id << " "
27375+ << notification_id << " " << from_message_id << " " << from_notification_id;
2737527376 is_correct = false;
2737627377 } else {
2737727378 from_message_id = m->message_id;
@@ -27610,7 +27611,7 @@ void MessagesManager::on_get_message_notifications_from_database(DialogId dialog
2761027611
2761127612 auto notification_id = m->notification_id.is_valid() ? m->notification_id : m->removed_notification_id;
2761227613 if (!notification_id.is_valid()) {
27613- VLOG(ERROR) << "Can't find notification ID for " << m->message_id << " in " << d->dialog_id;
27614+ VLOG(ERROR) << "Can't find notification identifier for " << m->message_id << " in " << d->dialog_id;
2761427615 continue;
2761527616 }
2761627617 CHECK(m->message_id.is_valid());
@@ -31958,7 +31959,7 @@ MessagesManager::Message *MessagesManager::add_message_to_dialog(Dialog *d, uniq
3195831959 << d->last_new_message_id << " to " << message_id;
3195931960 }
3196031961 LOG(ERROR) << "New " << message_id << " in " << dialog_id << " from " << source
31961- << " has id less than last_new_message_id = " << d->last_new_message_id;
31962+ << " has identifier less than last_new_message_id = " << d->last_new_message_id;
3196231963 dump_debug_message_op(d);
3196331964 }
3196431965 }
@@ -32404,7 +32405,7 @@ MessagesManager::Message *MessagesManager::add_message_to_dialog(Dialog *d, uniq
3240432405 set_dialog_last_read_inbox_message_id(d, MessageId::min(), server_unread_count, local_unread_count, false,
3240532406 source);
3240632407 } else {
32407- // if non-scheduled outgoing message has id one greater than last_read_inbox_message_id,
32408+ // if non-scheduled outgoing message has identifier one greater than last_read_inbox_message_id,
3240832409 // then definitely there are no unread incoming messages before it
3240932410 if (message_id.is_server() && d->last_read_inbox_message_id.is_valid() &&
3241032411 d->last_read_inbox_message_id.is_server() &&
@@ -33263,9 +33264,10 @@ bool MessagesManager::update_message(Dialog *d, Message *old_message, unique_ptr
3326333264 CHECK(!is_scheduled);
3326433265 if (old_message->notification_id.is_valid()) {
3326533266 if (new_message->notification_id.is_valid()) {
33266- LOG(ERROR) << "Notification id for " << message_id << " in " << dialog_id << " has tried to change from "
33267- << old_message->notification_id << " to " << new_message->notification_id
33268- << ", message content type is " << old_content_type << '/' << new_content_type;
33267+ LOG(ERROR) << "Notification identifier for " << message_id << " in " << dialog_id
33268+ << " has tried to change from " << old_message->notification_id << " to "
33269+ << new_message->notification_id << ", message content type is " << old_content_type << '/'
33270+ << new_content_type;
3326933271 }
3327033272 } else {
3327133273 CHECK(new_message->notification_id.is_valid());
@@ -33945,11 +33947,11 @@ void MessagesManager::fix_new_dialog(Dialog *d, unique_ptr<Message> &&last_datab
3394533947 }
3394633948 if (being_added_dialog_id_ != dialog_id && !d->is_folder_id_inited && !td_->auth_manager_->is_bot() &&
3394733949 order != DEFAULT_ORDER) {
33948- // asynchronously get dialog folder id from the server
33950+ // asynchronously get dialog folder identifier from the server
3394933951 get_dialog_info_full(dialog_id, Auto());
3395033952 }
3395133953 if (!d->is_message_ttl_setting_inited && !td_->auth_manager_->is_bot() && order != DEFAULT_ORDER) {
33952- // asynchronously get dialog message ttl setting from the server
33954+ // asynchronously get dialog message TTL setting from the server
3395333955 get_dialog_info_full(dialog_id, Auto());
3395433956 }
3395533957 if (!d->know_action_bar && !td_->auth_manager_->is_bot() && dialog_type != DialogType::SecretChat &&
0 commit comments