Skip to content

Commit b23f333

Browse files
kxxttargos
kxxt
authored and
targos
committed
deps: V8: cherry-pick a3cc8522a4c8
Original commit message: [riscv] avoid cpu probing in li_ptr CPU probing is an expensive thing to do and we should avoid doing it upon every li_ptr call. Fixes performance regresion bisected in riscv-forks/electron#1 Change-Id: Ib5ff89b2a730e08de6735123ae60adeffe811ed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5612950 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#94349} Refs: v8/v8@a3cc852 PR-URL: nodejs#53412 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 98d6836 commit b23f333

3 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.8',
39+
'v8_embedder_string': '-node.9',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/AUTHORS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ Kevin Gibbons <bakkot@gmail.com>
182182
Keyhan Vakil <kvakil@googlecontrib.kvakil.me>
183183
Kris Selden <kris.selden@gmail.com>
184184
Kyounga Ra <kyounga@alticast.com>
185+
Levi Zim <rsworktech@outlook.com>
185186
Loo Rong Jie <loorongjie@gmail.com>
186187
Lu Yahan <yahan@iscas.ac.cn>
187188
Ludovic Mermod <ludovic.mermod@gmail.com>

‎deps/v8/src/codegen/riscv/assembler-riscv.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,6 @@ void Assembler::GeneralLi(Register rd, int64_t imm) {
11041104
}
11051105

11061106
void Assembler::li_ptr(Register rd, int64_t imm) {
1107-
base::CPU cpu;
11081107
// Initialize rd with an address
11091108
// Pointers are 48 bits
11101109
// 6 fixed instructions are generated

0 commit comments

Comments
 (0)