Skip to content

Domain support for Promises #364

Closed
Closed

Description

@ORESoftware

@isaacs this is for the people

hapijs/lab#695

I recommend using that patch with TapJS. It seems to work.
If you see any problems with it, I would love to know. Try out the code.

The standard problem:

Promise.resolve(null).then(function(){
   setTimeout(function(){
        throw 'this normally cannot be caught by domains, but with the patch, it can!'
   }, 100):
});

'nuff said

Activity

  1. ORESoftware commented on Apr 18, 2017

    @ORESoftware
    Author

    And there's this:
    nodejs/node#12489 (comment)

  2. isaacs commented on Jun 18, 2017

    @isaacs
    Member

    Works on node 8, gonna let time fix this one for us.

  3. ORESoftware commented on Jun 19, 2017

    @ORESoftware
    Author

    word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions