Skip to content

Commit 4e81668

Browse files
Ivan-ShamlBrutus5000
authored andcommitted
Fix logging bug in 'com.faforever.api.user.SteamService.parseSteamIdFromLoginRedirect'
1 parent 45845f4 commit 4e81668

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎src/main/java/com/faforever/api/user/SteamService.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,10 @@ String buildLoginUrl(String redirectUrl) {
4747
@SneakyThrows
4848
String parseSteamIdFromLoginRedirect(HttpServletRequest request) {
4949
log.trace("Parsing steam id from request: {}", request);
50-
return Optional.ofNullable(request.getParameter("openid.identity"))
50+
final String openIdIdentityParamName = "openid.identity";
51+
return Optional.ofNullable(request.getParameter(openIdIdentityParamName))
5152
.map(identityUrl -> identityUrl.substring(identityUrl.lastIndexOf("/") + 1))
52-
.orElseThrow(() -> {log.warn("Steam redirect could not be validated! The request does not contain 'openid.identity' parameter. Original OpenID response:\n {}", request);
53+
.orElseThrow(() -> {log.warn("Steam id could not be parsed! The request does not contain ''{}'' parameter.", openIdIdentityParamName);
5354
return ApiException.of(ErrorCode.STEAM_LOGIN_VALIDATION_FAILED);});
5455
}
5556

0 commit comments

Comments
 (0)