Skip to content

Commit 04cd1a5

Browse files
JReinholdstorybook-bot
authored andcommitted
Merge pull request #25642 from storybookjs/jeppe/fix-version-detection
CLI: Fix existing version detection in `upgrade` (cherry picked from commit 81db91d)
1 parent ed9f791 commit 04cd1a5

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎code/lib/cli/src/upgrade.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ export const doUpgrade = async ({
292292

293293
const packageManager = JsPackageManagerFactory.getPackageManager({ force: pkgMgr });
294294

295-
const beforeVersion = await getStorybookCoreVersion();
295+
// If we can't determine the existing version (Yarn PnP), fallback to v0.0.0 to not block the upgrade
296+
const beforeVersion = (await getStorybookCoreVersion()) ?? '0.0.0';
296297
const currentVersion = versions['@storybook/cli'];
297298
const isCanary = currentVersion.startsWith('0.0.0');
298299

‎code/lib/telemetry/src/package-json.ts‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@ export const getActualPackageJson = async (packageName: string) => {
2828
return packageJson;
2929
};
3030

31-
// Note that this probably doesn't work in PNPM mode
31+
// Note that this probably doesn't work in Yarn PNP mode because @storybook/telemetry doesn't depend on @storybook/cli
3232
export const getStorybookCoreVersion = async () => {
33-
const coreVersions = await Promise.all(
34-
['@storybook/core-common', '@storybook/core-server'].map(getActualPackageVersion)
35-
);
36-
return coreVersions.find((v) => v.version)?.version;
33+
const { version } = await getActualPackageVersion('@storybook/cli');
34+
return version;
3735
};

0 commit comments

Comments
 (0)