Skip to content

Commit 6a9d2f1

Browse files
committed
Some refactoring
1 parent 790be01 commit 6a9d2f1

9 files changed

Lines changed: 12 additions & 27 deletions

File tree

‎integration_tests/test_sonar_numpy_nan_equality.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from core_codemods.sonar_numpy_nan_equality import (
1+
from core_codemods.sonar.sonar_numpy_nan_equality import (
22
SonarNumpyNanEquality,
33
SonarNumpyNanEqualityTransformer,
44
)

‎src/codemodder/codemodder.py‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from codemodder.report.codetf_reporter import report_default
2121
from codemodder.result import ResultSet
2222
from codemodder.semgrep import run as run_semgrep
23-
from codemodder.sonar_results import SonarResultSet
2423

2524

2625
def update_code(file_path, new_code):
@@ -137,13 +136,6 @@ def record_dependency_update(dependency_results: dict[Dependency, PackageStore |
137136
logger.debug("The following dependencies could not be added: %s", str_list)
138137

139138

140-
def process_sonar_findings(sonar_json_files: list[str]) -> SonarResultSet:
141-
combined_result_set = SonarResultSet()
142-
for file in sonar_json_files or []:
143-
combined_result_set |= SonarResultSet.from_json(file)
144-
return combined_result_set
145-
146-
147139
def run(original_args) -> int:
148140
start = datetime.datetime.now()
149141

‎src/codemodder/codemods/base_codemod.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ def docs_module(self) -> Traversable:
108108

109109
@cached_property
110110
def description(self) -> str:
111-
if self._metadata.description == None:
111+
if self._metadata.description is None:
112112
doc_path = self.docs_module / f"{self.origin}_python_{self.name}.md"
113113
return doc_path.read_text()
114-
return self._metadata.description # type: ignore
114+
return self._metadata.description
115115

116116
@property
117117
def review_guidance(self):

‎src/codemodder/context.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,7 @@ def __init__(
6363
self.path_include = path_include
6464
self.path_exclude = path_exclude
6565
self.max_workers = max_workers
66-
if tool_result_files_map:
67-
self.tool_result_files_map = tool_result_files_map
68-
else:
69-
self.tool_result_files_map = {}
66+
self.tool_result_files_map = tool_result_files_map or {}
7067

7168
def add_results(self, codemod_name: str, change_sets: List[ChangeSet]):
7269
self._results_by_codemod.setdefault(codemod_name, []).extend(change_sets)

‎src/codemodder/registry.py‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,12 @@ def match_codemods(
6363
) -> list[BaseCodemod]:
6464
codemod_include = codemod_include or []
6565
codemod_exclude = codemod_exclude or DEFAULT_EXCLUDED_CODEMODS
66-
67-
if sast_only:
68-
base_list = [
69-
codemod for codemod in self.codemods if codemod.origin != "pixee"
70-
]
71-
else:
72-
base_list = [
73-
codemod for codemod in self.codemods if codemod.origin == "pixee"
74-
]
66+
base_list = [
67+
codemod
68+
for codemod in self.codemods
69+
if (sast_only and codemod.origin != "pixee")
70+
or (not sast_only and codemod.origin == "pixee")
71+
]
7572

7673
if codemod_exclude and not codemod_include:
7774
return [

‎src/core_codemods/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
from .remove_assertion_in_pytest_raises import RemoveAssertionInPytestRaises
5151
from .fix_assert_tuple import FixAssertTuple
5252

53-
from .sonar_numpy_nan_equality import SonarNumpyNanEquality
53+
from .sonar.sonar_numpy_nan_equality import SonarNumpyNanEquality
5454

5555
registry = CodemodCollection(
5656
origin="pixee",
File renamed without changes.

‎tests/codemods/test_sonar_numpy_nan_equality.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import json
2-
from core_codemods.sonar_numpy_nan_equality import SonarNumpyNanEquality
2+
from core_codemods.sonar.sonar_numpy_nan_equality import SonarNumpyNanEquality
33
from tests.codemods.base_codemod_test import BaseSASTCodemodTest
44
from textwrap import dedent
55

‎tests/test_codemod_docs.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ def pytest_generate_tests(metafunc):
1212

1313

1414
def test_load_codemod_docs_info(codemod: BaseCodemod):
15-
print(codemod.name)
1615
if codemod.name in ["order-imports"]:
1716
pytest.xfail(reason=f"{codemod.name} has no description")
1817

0 commit comments

Comments
 (0)