Skip to content

Implement Option to Enable/Disable RowIDs in DuckDBSchema #1160

Description

@Saahi30

In the DuckDBSchema.java file, there is a TODO comment indicating the need to implement an option to enable or disable rowids. Currently, the rowid column is added unconditionally, which may not be desirable in all use cases.

what I am talking about

// TODO: implement an option to enable/disable rowids
columns.add(new DuckDBColumn("rowid", new DuckDBCompositeDataType(DuckDBDataType.INT, 4), false, false));

what I'll change

  1. Implement a configuration option that allows users to enable or disable the inclusion of the rowid column in the DuckDB schema.
  2. Modify the logic in the DuckDBSchema class to check this configuration option before adding the rowid column.
  3. Update any relevant documentation to inform users about this new option and its implications.

Let me know if you need any clarifications on this....

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions