Problem when including spring profiles with logical operators #16303

Activity

1. spring-projects-issues

   added

   status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triaged

   on Mar 25, 2019
2. mbhave commented on Mar 26, 2019

   

   mbhave

   on Mar 26, 2019

   Contributor

   More actions

   Profile expressions (and negated profiles) get processed last, i.e. once we already know the profiles activated and included by the config files. If the YAML document that's activated by a profile expression itself contains a spring.profiles.include, that doesn't get processed at the moment.

   We'd have to go over the config files again to look for documents matching the profiles included by the expression. Let's see if the rest of the team thinks this is something we should fix.
3. mbhave

   added

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   on Mar 26, 2019
4. mbhave commented on Mar 27, 2019

   

   mbhave

   on Mar 27, 2019

   Contributor

   More actions

   Based on the complexity of the fix we can decide whether it should go in 2.1.x or 2.2.x.
5. mbhave

   added

   type: bugA general bugA general bug

   and removed

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triaged

   on Mar 27, 2019
6. mbhave

   added this to the 2.1.x milestone on Mar 27, 2019
7. mbhave

   self-assigned this

   on Mar 27, 2019
8. mbhave

   added

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   on Apr 5, 2019
9. philwebb

   removed

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   on Apr 5, 2019
10. mbhave commented on Apr 5, 2019

    

    mbhave

    on Apr 5, 2019

    Last edited by mbhave

    Contributor

    More actions

    I have a fix for this here but this is turning out to get a bit complicated because of the way included profiles are supposed to be ordered. For example, look at the configuration below:

    spring.profiles: a
    spring.profiles.include: c
    ---
    spring.profiles: a & b
    spring.profiles.include: d,e
    ---
    spring.profiles: d
    spring.profiles.include: f
    ---

    Given that profiles a and b are active, the above configuration will lead to a profile order of a, c, b, d, e, f, whereas one might expect it to be a, c, b, d, f, e. There are a lot of corner cases when it comes to profiles specific files/YAML documents and include profiles. We need to take a step back and redefine the rules, which will lead to a possible overhaul of this part of the code. We can tackle this in 2.3.x once we have a better idea of what it should look like.
11. mbhave

    modified the milestones: 2.1.x, 2.x on Apr 5, 2019
12. mbhave

    added

    theme: profiles

    on Apr 24, 2019
13. mbhave

    added

    for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

    on Jul 31, 2020
14. philwebb

    modified the milestones: 2.x, 2.4.x on Jul 31, 2020
15. philwebb

    self-assigned this

    on Jul 31, 2020
16. philwebb

    removed

    for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

    on Jul 31, 2020
17. mbhave

    added

    theme: config-dataIssues related to the configuration themeIssues related to the configuration theme

    and removed

    theme: profiles

    on Aug 5, 2020
18. philwebb commented on Oct 23, 2020

    

    philwebb

    on Oct 23, 2020

    Member

    More actions

    Spring Boot 2.4 has overhauled config processing. See this blog post for details. Since the spring.profiles.include property won't be supported going forward you'll need to find a different way to do what you want.

    I would suggest using @Profile("a & b") directly in your code or adding an EnvironmentPostProcessor to set new profiles based on the existing ones.

    I'm going to close this one for now, but if you find there's an obvious use-case that we're missing from the new code then please comment back here and we can have another look. We'll need a bit more background about what's driving the need for the includeAandB profile in the first place.
19. philwebb

    closed this as completedon Oct 23, 2020
20. philwebb

    added

    status: declinedA suggestion or change that we don't feel we should currently applyA suggestion or change that we don't feel we should currently apply

    and removed

    theme: config-dataIssues related to the configuration themeIssues related to the configuration theme

    type: bugA general bugA general bug

    on Oct 23, 2020
21. philwebb

    removed this from the 2.4.x milestone on Oct 23, 2020