Skip to content

Personalization missing functions #1080

Description

@PELock

1st bug

Adding header to the message before adding personalization, creates an empty personalization object within the email object, and when you add following personalization with recipients emails, your interface throws error because the first personalization initialized by adding header doesn't contain TO field! Who wrote this code??? Seriously, this is bad design decision...

2nd I dunno missing feature

$personalization->addHeader("key", "value");

doesn't work like we do it for the single email, we need to do:

$personalization->addHeader(\SendGrid\Mail\Header("key", "value"));

just add wrapper to handle it like it's done for the $email->addHeader(key, value)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions