Skip to content

Commit 5f854c2

Browse files
authored
Fixes bugs impacting investigation document and incident resources Slack message (Netflix#158)
* Removes deprecated form weblink and makes conference weblink optional * Fixes broken conference weblink in incident resources message
1 parent 1115f57 commit 5f854c2

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

‎src/dispatch/incident/flows.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,9 @@ def update_document(
281281
commander_fullname: str,
282282
conversation_weblink: str,
283283
document_weblink: str,
284-
conference_weblink: str,
285284
storage_weblink: str,
286285
ticket_weblink: str,
287-
form_weblink: str = None,
286+
conference_weblink: str = None,
288287
):
289288
"""Update external collaboration document."""
290289
p = plugins.get(INCIDENT_PLUGIN_DOCUMENT_SLUG)
@@ -300,7 +299,6 @@ def update_document(
300299
document_weblink=document_weblink,
301300
storage_weblink=storage_weblink,
302301
ticket_weblink=ticket_weblink,
303-
form_weblink=form_weblink,
304302
conference_weblink=conference_weblink,
305303
)
306304

‎src/dispatch/incident/messaging.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,7 @@ def send_incident_resources_ephemeral_message_to_participant(
559559
storage_weblink=incident.storage.weblink,
560560
faq_weblink=incident_faq.weblink,
561561
conversation_commands_reference_document_weblink=incident_conversation_commands_reference_document.weblink,
562+
conference_weblink=incident.conference.weblink,
562563
)
563564

564565
log.debug(f"List of incident resources sent to {user_id} via ephemeral message.")

0 commit comments

Comments
 (0)