-
-
Notifications
You must be signed in to change notification settings - Fork 742
Comparing changes
Open a pull request
base repository: screego/server
base: update
head repository: screego/server
compare: master
- 9 commits
- 5 files changed
- 5 contributors
Commits on Apr 25, 2026
-
Configuration menu - View commit details
-
Copy full SHA for be8b0f0 - Browse repository at this point
Copy the full SHA be8b0f0View commit details
Commits on May 10, 2026
-
Co-authored-by: Copilot <copilot@github.com>
Configuration menu - View commit details
-
Copy full SHA for 8d1d80b - Browse repository at this point
Copy the full SHA 8d1d80bView commit details
Commits on May 13, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 8c82c11 - Browse repository at this point
Copy the full SHA 8c82c11View commit details -
Merge pull request #245 from dongdigua/master
Add support for riscv64
Configuration menu - View commit details
-
Copy full SHA for f946cee - Browse repository at this point
Copy the full SHA f946ceeView commit details
Commits on Aug 1, 2026
-
Configuration menu - View commit details
-
Copy full SHA for eab1506 - Browse repository at this point
Copy the full SHA eab1506View commit details
Commits on Aug 20, 2026
-
fix: don't close peer connection on transient 'disconnected' state
Both connectionstatechange handlers treated 'disconnected' the same as 'closed' and 'failed' and immediately called peer.close(). Per the WebRTC spec, 'disconnected' only means that ICE connectivity checks are currently failing. The connection frequently recovers on its own -- brief network hiccups, Wi-Fi roaming between access points, or NAT rebinding all trigger it. Calling close() makes that recovery impossible, because a closed RTCPeerConnection cannot be reopened. The result was that a short network glitch permanently killed the stream and the viewer had to reload the page. Leaving 'disconnected' unhandled lets the browser's own ICE recovery do its job. Refs #53
Configuration menu - View commit details
-
Copy full SHA for 9f87229 - Browse repository at this point
Copy the full SHA 9f87229View commit details -
Merge pull request #250 from swindi-dev/fix/transient-disconnected
fix: don't close peer connection on transient 'disconnected' state
Configuration menu - View commit details
-
Copy full SHA for 7dec440 - Browse repository at this point
Copy the full SHA 7dec440View commit details
Commits on Sep 26, 2026
-
fix(ui): decode room id from URL and encode it when writing back
The room id was read from the query string with a hand-rolled parser that never decoded it, while the id was written back into the URL without any encoding: getFromURL = (key, search) => search.slice(1).split('&') .find((param) => param.startsWith(`${key}=`))?.split('=')[1]; window.history.pushState({roomId: id}, '', id ? `?room=${id}` : '?'); Browsers percent-encode non-ASCII characters when a URL is serialized, so a room named "不辞" is shared as `?room=%E4%B8%8D%E8%BE%9E`, but the client then joins the literal `%E4%B8%8D%E8%BE%9E` room, which does not exist: -> {"type":"join","payload":{"id":"%E4%B8%8D%E8%BE%9E"}} <- close 1000 "room with id %E4%B8%8D%E8%BE%9E does not exist" The same asymmetry also broke ids containing `&`, `=`, `+`, `#` or `%`, and made ids that already contain percent escapes gain another encoding level on every write, producing broken (double encoded) share links. Use the platform URL API, which decodes on read and encodes on write exactly once: new URLSearchParams(search).get(key) ?? undefined const params = new URLSearchParams(); params.set('room', id); window.history.pushState({roomId: id}, '', `?${params.toString()}`); No server change is needed: the room id stays the raw, human-readable string that the ws `create`/`join` payload and the server-side room map already use, and existing share links keep working. Verified: URL round-trip for 不辞 / "my room" / "a+b" / "a&b=c" / "100%", protocol-level e2e against a live server (encoded id -> "does not exist", decoded id -> joins, cleanup on owner leave), `yarn build` (tsc + vite) and `prettier --check src/useRoomID.ts`.Configuration menu - View commit details
-
Copy full SHA for fc98902 - Browse repository at this point
Copy the full SHA fc98902View commit details
Commits on Sep 27, 2026
-
Merge pull request #254 from LandmineHQ/fix/room-id-url-encoding
fix(ui): decode room id from URL and encode it when writing back
Configuration menu - View commit details
-
Copy full SHA for 4ae5f44 - Browse repository at this point
Copy the full SHA 4ae5f44View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff update...master