Repository navigation
8.12 CMS: support CELL_SIZE, fix CMS.INFO field parsing, cover negative INCRBY #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 4 commits
e940b7c
8ce6301
8f65407
c7f71a5
2272e60
3b395bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,12 @@ | ||
| #nullable enable | ||
| NRedisStack.CountMinSketch.DataTypes.CmsInformation.CellSize.get -> int | ||
|
Check warning on line 2 in src/NRedisStack/PublicAPI/PublicAPI.Unshipped.txt
|
||
| NRedisStack.CmsCommands.InitByDim(StackExchange.Redis.RedisKey key, long width, long depth, int cellSize) -> bool | ||
| NRedisStack.CmsCommands.InitByProb(StackExchange.Redis.RedisKey key, double error, double probability, int cellSize) -> bool | ||
| NRedisStack.CmsCommandsAsync.InitByDimAsync(StackExchange.Redis.RedisKey key, long width, long depth, int cellSize) -> System.Threading.Tasks.Task<bool>! | ||
| NRedisStack.CmsCommandsAsync.InitByProbAsync(StackExchange.Redis.RedisKey key, double error, double probability, int cellSize) -> System.Threading.Tasks.Task<bool>! | ||
| NRedisStack.ICmsCommands.InitByDim(StackExchange.Redis.RedisKey key, long width, long depth, int cellSize) -> bool | ||
| NRedisStack.ICmsCommands.InitByProb(StackExchange.Redis.RedisKey key, double error, double probability, int cellSize) -> bool | ||
| NRedisStack.ICmsCommandsAsync.InitByDimAsync(StackExchange.Redis.RedisKey key, long width, long depth, int cellSize) -> System.Threading.Tasks.Task<bool>! | ||
| NRedisStack.ICmsCommandsAsync.InitByProbAsync(StackExchange.Redis.RedisKey key, double error, double probability, int cellSize) -> System.Threading.Tasks.Task<bool>! | ||
| static NRedisStack.CmsCommandBuilder.InitByDim(StackExchange.Redis.RedisKey key, long width, long depth, int cellSize) -> NRedisStack.RedisStackCommands.SerializedCommand! | ||
| static NRedisStack.CmsCommandBuilder.InitByProb(StackExchange.Redis.RedisKey key, double error, double probability, int cellSize) -> NRedisStack.RedisStackCommands.SerializedCommand! | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -516,7 +516,7 @@ public static CmsInformation | |
| case "count": | ||
| count = (long)redisResults[i]; | ||
| break; | ||
| case "cell size": | ||
| case "cell_size": | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When querying Redis 8.10, this regresses Useful? React with 👍 / 👎. |
||
| cellSize = (int)redisResults[i]; | ||
| break; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Environment variables for Redis 8.12 | ||
| # Used by the run-tests GitHub Action | ||
|
|
||
| # No official 8.12 release image exists yet, so this is pinned to an unstable | ||
| # preview build. Unlike the other .env.v* files, this tag is not guaranteed to | ||
| # stay available - replace with the real release image once 8.12 ships. | ||
| CLIENT_LIBS_TEST_IMAGE=redislabs/client-libs-test:unstable-34786335206-debian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate shipped CellSize public API
Low Severity
CmsInformation.CellSizeis appended toPublicAPI.Unshipped.txt, but that getter is already recorded inPublicAPI.Shipped.txt. The property signature did not change in this PR, so the unshipped line is a duplicate.eng/public-api.py --promotetreats this as a clash (and notes that the analyzer reports RS0025), so the next release promotion will fail until the extra entry is removed.Reviewed by Cursor Bugbot for commit c7f71a5. Configure here.