Skip to content

Commit a82f127

Browse files
mgravellmgravell
authored
Drop explicit Microsoft.SourceLink.GitHub reference (#565)
The .NET SDK has included and enabled Source Link for GitHub-hosted repos by default since 8.0.100; our pinned SDK (10.0.101+, rollForward latestMajor) is well past that. Referencing the package explicitly overrides the SDK's own bundled version, taking on a dependency and its future CVE/version churn for nothing. Verified the generated *.sourcelink.json and packed nuspec <repository> element are unchanged across all target frameworks (net481, netstandard2.0, net6.0/8.0/10.0).
1 parent 1f55c94 commit a82f127

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

‎Directory.Build.props‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
<ItemGroup>
4444
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" IncludeAssets="runtime; build; native; contentfiles; analyzers"/>
45-
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All"/>
4645
<!--<PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all"/>-->
4746
</ItemGroup>
4847
</Project>

‎Directory.Packages.props‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<!-- core build -->
44
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
55
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
6-
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.401" />
76
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.7.115" />
87
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.6.0">
98
<PrivateAssets>all</PrivateAssets>

0 commit comments

Comments
 (0)