Skip to content

Commit d1448fc

Browse files
committed
restore test
switch provisioner validation to cast to []interface{} first
1 parent 7322116 commit d1448fc

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

‎builtin/provisioners/habitat/resource_provisioner.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,8 @@ func validateFn(c *terraform.ResourceConfig) (ws []string, es []error) {
293293
// Validate service level configs
294294
services, ok := c.Get("service")
295295
if ok {
296-
for _, service := range services.([]map[string]interface{}) {
296+
for _, svc := range services.([]interface{}) {
297+
service := svc.(map[string]interface{})
297298
strategy, ok := service["strategy"].(string)
298299
if ok && !updateStrategies[strategy] {
299300
es = append(es, errors.New(strategy+" is not a valid update strategy."))

‎builtin/provisioners/habitat/resource_provisioner_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ func TestResourceProvisioner_Validate_bad(t *testing.T) {
4747
}
4848
}
4949

50-
/* FIXME panic: interface conversion: interface {} is []interface {}, not []map[string]interface {}
5150
func TestResourceProvisioner_Validate_bad_service_config(t *testing.T) {
5251
c := testConfig(t, map[string]interface{}{
5352
"service": []interface{}{
@@ -68,7 +67,6 @@ func TestResourceProvisioner_Validate_bad_service_config(t *testing.T) {
6867
t.Fatalf("Should have three errors")
6968
}
7069
}
71-
*/
7270

7371
func testConfig(t *testing.T, c map[string]interface{}) *terraform.ResourceConfig {
7472
return terraform.NewResourceConfigRaw(c)

0 commit comments

Comments
 (0)