Skip to content

Commit 6d4e02e

Browse files
Chanh Huamildwonkey
authored andcommitted
Fix passing wrong file info & Add test coverage
1 parent 6ecee4e commit 6d4e02e

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎tools/terraform-bundle/e2etest/package_test.go‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,9 @@ func TestPackage_manyProviders(t *testing.T) {
125125

126126
for _, file := range read.File {
127127
if _, exists := expectedFiles[file.Name]; exists {
128+
if !file.FileInfo().Mode().IsRegular() {
129+
t.Errorf("Expected file is not a regular file: %s", file.Name)
130+
}
128131
delete(expectedFiles, file.Name)
129132
} else {
130133
extraFiles[file.Name] = struct{}{}
@@ -195,6 +198,9 @@ func TestPackage_localProviders(t *testing.T) {
195198

196199
for _, file := range read.File {
197200
if _, exists := expectedFiles[file.Name]; exists {
201+
if !file.FileInfo().Mode().IsRegular() {
202+
t.Errorf("Expected file is not a regular file: %s", file.Name)
203+
}
198204
delete(expectedFiles, file.Name)
199205
} else {
200206
extraFiles[file.Name] = struct{}{}

‎tools/terraform-bundle/package.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ func (c *PackageCommand) Run(args []string) int {
226226
return addZipFile(
227227
filepath.Join(linkPath, file.Name()), // the link to this provider binary
228228
filepath.Join(relPath, file.Name()), // the expected directory for the binary
229-
info, outZ,
229+
file, outZ,
230230
)
231231
}
232232
}

0 commit comments

Comments
 (0)