Skip to content

Commit cd3445e

Browse files
zombieFoxzombieFox
committed
[refactor] improve sorting controls
1 parent c36a90b commit cd3445e

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎src/css/link.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@
562562
justify-content: center;
563563
}
564564

565-
.is-sorting .link-empty {
565+
.is-sorting-link .link-empty {
566566
display: none;
567567
}
568568

‎src/js/link.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -254,11 +254,11 @@ var link = (function() {
254254
helper.eA(".group-body").forEach(function(arrayItem, index) {
255255
sortable(arrayItem)[0].addEventListener("sortstart", function() {
256256
var html = helper.e("html");
257-
helper.addClass(html, "is-sorting");
257+
helper.addClass(html, "is-sorting-link");
258258
}, false);
259259
sortable(arrayItem)[0].addEventListener("sortstop", function() {
260260
var html = helper.e("html");
261-
helper.removeClass(html, "is-sorting");
261+
helper.removeClass(html, "is-sorting-link");
262262
}, false);
263263
sortable(arrayItem)[0].addEventListener("sortupdate", bind.sort.update.func.item, false, event);
264264
});
@@ -361,27 +361,27 @@ var link = (function() {
361361
var groupBody = helper.node("div|class:group-body");
362362
group.appendChild(groupBody);
363363

364-
var itemGroupControlItemUp = helper.node("button|class:button button-small group-control-item group-control-item-up,tabindex:-1,title:Move this bookmark up");
364+
var itemGroupControlItemUp = helper.node("button|class:button button-small group-control-item group-control-item-up,tabindex:-1,title:Move this group up");
365365
var itemGroupControlItemUpIcon = helper.node("span|class:button-icon icon-arrow-up");
366366
itemGroupControlItemUp.appendChild(itemGroupControlItemUpIcon);
367367
groupControl.appendChild(itemGroupControlItemUp);
368368

369-
var itemGroupControlItemHandle = helper.node("div|class:button button-small group-control-item group-control-item-handle,tabindex:-1,title:Drag and drop to reorder");
369+
var itemGroupControlItemHandle = helper.node("div|class:button button-small group-control-item group-control-item-handle,tabindex:-1,title:Drag group to reorder");
370370
var itemGroupControlItemHandleIcon = helper.node("span|class:button-icon icon-reorder");
371371
itemGroupControlItemHandle.appendChild(itemGroupControlItemHandleIcon);
372372
groupControl.appendChild(itemGroupControlItemHandle);
373373

374-
var itemGroupControlItemDown = helper.node("button|class:button button-small group-control-item group-control-item-down,tabindex:-1,title:Move this bookmark down");
374+
var itemGroupControlItemDown = helper.node("button|class:button button-small group-control-item group-control-item-down,tabindex:-1,title:Move this group down");
375375
var itemGroupControlItemDownIcon = helper.node("span|class:button-icon icon-arrow-down");
376376
itemGroupControlItemDown.appendChild(itemGroupControlItemDownIcon);
377377
groupControl.appendChild(itemGroupControlItemDown);
378378

379-
var itemGroupControlItemEdit = helper.node("button|class:button button-small group-control-item group-control-item-edit,tabindex:-1,title:Edit this bookmark");
379+
var itemGroupControlItemEdit = helper.node("button|class:button button-small group-control-item group-control-item-edit,tabindex:-1,title:Edit this group");
380380
var itemGroupControlItemEditIcon = helper.node("span|class:button-icon icon-edit");
381381
itemGroupControlItemEdit.appendChild(itemGroupControlItemEditIcon);
382382
groupControl.appendChild(itemGroupControlItemEdit);
383383

384-
var itemGroupControlItemRemove = helper.node("button|class:button button-small group-control-item group-control-item-remove,tabindex:-1,title:Remove this bookmark");
384+
var itemGroupControlItemRemove = helper.node("button|class:button button-small group-control-item group-control-item-remove,tabindex:-1,title:Remove this group");
385385
var itemGroupControlItemRemoveIcon = helper.node("span|class:button-icon icon-close");
386386
itemGroupControlItemRemove.appendChild(itemGroupControlItemRemoveIcon);
387387
groupControl.appendChild(itemGroupControlItemRemove);
@@ -578,7 +578,7 @@ var link = (function() {
578578
}]
579579
});
580580
var linkControl = helper.node("div|class:link-control");
581-
var linkHandle = helper.node("div|class:button button-small link-control-item link-control-item-handle,tabindex:-1,title:Drag and drop to reorder");
581+
var linkHandle = helper.node("div|class:button button-small link-control-item link-control-item-handle,tabindex:-1,title:Drag bookmark to reorder");
582582
var linkHandleIcon = helper.node("span|class:button-icon icon-reorder");
583583
var linkEdit = helper.node("button|class:button button-small link-control-item link-control-item-edit,tabindex:-1,title:Edit this bookmark");
584584
var linkEditIcon = helper.node("span|class:button-icon icon-edit");

0 commit comments

Comments
 (0)