Skip to content

Commit 7862f5c

Browse files
zombieFoxzombieFox
committed
[design] improve auto suggest width
1 parent 94c94be commit 7862f5c

6 files changed

Lines changed: 18 additions & 8 deletions

File tree

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nightTab",
3-
"version": "5.52.0",
3+
"version": "5.53.0",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
55
"main": "index.js",
66
"scripts": {

‎src/js/auto-suggest.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var autoSuggest = (function() {
2727
bind.input = function(override) {
2828
var options = {
2929
input: null,
30-
widthAnchor: null,
30+
anchorElement: null,
3131
type: null,
3232
postFocus: null
3333
};
@@ -210,8 +210,9 @@ var autoSuggest = (function() {
210210
top: autoSuggestInput.getBoundingClientRect().bottom + window.scrollY,
211211
width: autoSuggestInput.getBoundingClientRect().width
212212
};
213-
if (options.widthAnchor == "parent") {
214-
box.width = autoSuggestInput.parentElement.getBoundingClientRect().width;
213+
if (options.anchorElement) {
214+
box.width = options.anchorElement.getBoundingClientRect().width;
215+
box.left = options.anchorElement.getBoundingClientRect().left;
215216
};
216217
var autoSuggest = helper.node("div|class:auto-suggest list-unstyled is-jello");
217218
var autoSuggestList = helper.node("ul|class:auto-suggest-list list-unstyled");

‎src/js/link.js‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1769,6 +1769,8 @@ var link = (function() {
17691769
var wideLabel = render.form.label("link-form-wide", "Wide tile", "Bookmark tile to span across two columns.", true);
17701770
var tallInput = helper.node("input|type:checkbox,class:link-form-tall,id:link-form-tall,tabindex:1");
17711771
var tallLabel = render.form.label("link-form-tall", "Tall tile", "Bookmark tile to span across two rows.", true);
1772+
var wideTallLabelHelper = render.form.helper("link-form-wide-tall-helper", "Bookmark tile will span across two columns or rows if the Bookmark Area is large enough.");
1773+
17721774

17731775
// content
17741776
var displayAlignmentLabel = render.form.label(false, "Visual element and Name alignment");
@@ -1940,6 +1942,9 @@ var link = (function() {
19401942
tallInput,
19411943
tallLabel
19421944
]),
1945+
render.form.wrap([
1946+
wideTallLabelHelper
1947+
]),
19431948
helper.node("hr"),
19441949
render.form.wrap([
19451950
displayLetterSizeLabel,
@@ -2883,6 +2888,7 @@ var link = (function() {
28832888
helper.removeClass(wideLabel, "disabled");
28842889
tallInput.removeAttribute("disabled");
28852890
helper.removeClass(tallLabel, "disabled");
2891+
helper.removeClass(wideTallLabelHelper, "disabled");
28862892
helper.removeClass(displayAlignmentLabel, "disabled");
28872893
displayAlignmentTopLeftRadio.removeAttribute("disabled");
28882894
displayAlignmentTopCenterRadio.removeAttribute("disabled");
@@ -2930,6 +2936,7 @@ var link = (function() {
29302936
helper.addClass(wideLabel, "disabled");
29312937
tallInput.setAttribute("disabled", "");
29322938
helper.addClass(tallLabel, "disabled");
2939+
helper.addClass(wideTallLabelHelper, "disabled");
29332940
helper.addClass(displayAlignmentLabel, "disabled");
29342941
displayAlignmentTopLeftRadio.setAttribute("disabled", "");
29352942
displayAlignmentTopCenterRadio.setAttribute("disabled", "");
@@ -3805,9 +3812,11 @@ var link = (function() {
38053812
disableForm();
38063813
});
38073814

3815+
var autoSuggestAnchor = displayIconFormGroupText.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode;
3816+
38083817
autoSuggest.bind.input({
38093818
input: displayIconInput,
3810-
widthAnchor: "parent",
3819+
anchorElement: autoSuggestAnchor,
38113820
type: "fontawesomeIcon",
38123821
postFocus: displayIconFormGroupText
38133822
});

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var version = (function() {
22

3-
var current = "5.52.0";
3+
var current = "5.53.0";
44

55
var name = "Jaded Raven";
66

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "5.52.0",
5+
"version": "5.53.0",
66
"manifest_version": 2,
77
"chrome_url_overrides": {
88
"newtab": "index.html"

0 commit comments

Comments
 (0)