Skip to content

Commit a250ba4

Browse files
committed
fix more broken method stubs/expectations, remove spurious debugging
1 parent 2ae853b commit a250ba4

5 files changed

Lines changed: 5 additions & 44 deletions

File tree

‎chef/lib/chef/provider/group/dscl.rb‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ def set_gid
7373
end
7474

7575
def set_members
76-
pp :set_members => {:append => @new_resource.append, :members => @new_resource.members}
7776
unless @new_resource.append
7877
Chef::Log.debug("#{@new_resource}: removing group members #{@current_resource.members.join(' ')}") unless @current_resource.members.empty?
7978
safe_dscl("create /Groups/#{@new_resource.group_name} GroupMembers ''") # clear guid list

‎chef/spec/unit/client_spec.rb‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@
8888
Chef::Config.node_path(File.expand_path(File.join(CHEF_SPEC_DATA, "run_context", "nodes")))
8989
Chef::Config.cookbook_path(File.expand_path(File.join(CHEF_SPEC_DATA, "run_context", "cookbooks")))
9090
client = Chef::Client.new
91+
92+
client.node = node
93+
9194
client.stub!(:sync_cookbooks).and_return({})
9295
client.run
9396

‎chef/spec/unit/handler/json_file_spec.rb‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@
5252
it "saves run status data to a file as JSON" do
5353
@handler.should_receive(:build_report_dir)
5454
@handler.run_report_unsafe(@run_status)
55-
puts @run_status.exception
5655
reported_data = JSON.parse(@file_mock.string)
57-
pp reported_data
5856
reported_data['exception'].should == "Exception: Boy howdy!"
5957
reported_data['start_time'].should == @expected_time.iso8601
6058
reported_data['end_time'].should == (@expected_time + 5).iso8601

‎chef/spec/unit/lwrp_spec.rb‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@
136136
res.provider(:lwrp_monkey_name_printer)
137137
@run_context.resource_collection.insert(res)
138138

139-
STDOUT.should_receive(:write).with("my monkey's name is 'bob'").exactly(:once)
140-
STDOUT.should_receive(:write).with("\n").exactly(:once)
139+
STDOUT.should_receive(:puts).with("my monkey's name is 'bob'").exactly(:once)
141140
Chef::Runner.new(@run_context).converge
142141
end
143142

@@ -148,8 +147,7 @@
148147
res.provider(:lwrp_embedded_resource_accesses_providers_scope)
149148
@run_context.resource_collection.insert(res)
150149

151-
STDOUT.should_receive(:write).with("my monkey's name is 'bob, the monkey'").exactly(:once)
152-
STDOUT.should_receive(:write).with("\n").exactly(:once)
150+
STDOUT.should_receive(:puts).with("my monkey's name is 'bob, the monkey'").exactly(:once)
153151
Chef::Runner.new(@run_context).converge
154152
end
155153

‎chef/spec/unit/provider/group/dscl_spec.rb‎

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -148,20 +148,6 @@
148148
end
149149

150150
describe "set_gid" do
151-
# before do
152-
# @node = Chef::Node.new
153-
# @new_resource = mock("Chef::Resource::Group",
154-
# :null_object => true,
155-
# :group_name => "aj",
156-
# :gid => 50,
157-
# :members => [ "root", "aj"]
158-
# )
159-
# @provider = Chef::Provider::Group::Dscl.new(@node, @new_resource)
160-
# @provider.stub!(:get_free_gid).and_return(501)
161-
# @provider.stub!(:gid_used?).and_return(false)
162-
# @provider.stub!(:safe_dscl).and_return(true)
163-
# end
164-
165151
describe "with the new resource and a gid number which is already in use" do
166152
before do
167153
@provider.stub!(:gid_used?).and_return(true)
@@ -173,19 +159,6 @@
173159
end
174160

175161
describe "with no gid number for the new resources" do
176-
# before do
177-
# @new_resource = mock("Chef::Resource::Group",
178-
# :null_object => true,
179-
# :group_name => "aj",
180-
# :gid => nil,
181-
# :members => [ "root", "aj"]
182-
# )
183-
# @provider = Chef::Provider::Group::Dscl.new(@node, @new_resource)
184-
# @provider.stub!(:get_free_gid).and_return(501)
185-
# @provider.stub!(:gid_used?).and_return(false)
186-
# @provider.stub!(:safe_dscl).and_return(true)
187-
# end
188-
189162
it "should run get_free_gid and return a valid, unused gid number" do
190163
@provider.should_receive(:get_free_gid).and_return(501)
191164
@provider.set_gid
@@ -314,16 +287,6 @@
314287
end
315288

316289
describe "remove_group" do
317-
# before do
318-
# @node = Chef::Node.new
319-
# @new_resource = mock("Chef::Resource::Group",
320-
# :null_object => true,
321-
# :group_name => "aj"
322-
# )
323-
# @provider = Chef::Provider::Group::Dscl.new(@node, @new_resource)
324-
# @provider.stub!(:safe_dscl).and_return(true)
325-
# end
326-
327290
it "should run safe_dscl with delete /Groups/group and with the new resources group name" do
328291
@provider.should_receive(:safe_dscl).with("delete /Groups/aj").and_return(true)
329292
@provider.remove_group

0 commit comments

Comments
 (0)