Skip to content

Commit 3e7c766

Browse files
markmandelRobert Bailey
markmandel
authored and
Robert Bailey
committed
Flaky: Make preview --no-promote to avoid promotion race conditions (agones-dev#926)
This sometimes breaks CI, when two app engine apps try and be promoted at the same time.
1 parent 98d42dc commit 3e7c766

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎cloudbuild.yaml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ steps:
162162
# Site preview
163163
#
164164

165+
# don't promote, as it can cause failures when two deploys try and promote at the same time.
166+
165167
- name: "make-docker" # build a preview of the website
166168
id: site-static
167169
waitFor:
@@ -178,7 +180,7 @@ steps:
178180
waitFor:
179181
- site-gopath
180182
dir: "go/src/site"
181-
args: ["app", "deploy", ".app.yaml", "--promote", "--version=$SHORT_SHA"]
183+
args: ["app", "deploy", ".app.yaml", "--no-promote", "--version=$SHORT_SHA"]
182184
env:
183185
- GOPATH=/workspace/go
184186

0 commit comments

Comments
 (0)