Skip to content

Commit 3e5f17f

Browse files
markmandelRobert Bailey
markmandel
and
Robert Bailey
authored
Fix double build of SDK binary in Makefile (agones-dev#2612)
Previously we were building each of the SDK binaries for both arm64 amd amd64 which could potentially run into each other during builds. So being specific instead, which is faster, and also avoids race conditions. Co-authored-by: Robert Bailey <robertbailey@google.com>
1 parent 04b23b4 commit 3e5f17f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎build/Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -478,9 +478,9 @@ ifeq ($(WITH_WINDOWS), 1)
478478
build-agones-sdk-image: build-agones-sdk-image-windows
479479
endif
480480

481-
build-agones-sdk-image-amd64: $(ensure-build-image) build-agones-sdk-binary
481+
build-agones-sdk-image-amd64: $(ensure-build-image) build-agones-sdk-binary-linux-amd64
482482
docker build $(agones_path)/cmd/sdk-server/ --tag=$(sidecar_linux_amd64_tag) $(DOCKER_BUILD_ARGS)
483-
build-agones-sdk-image-arm64: $(ensure-build-image) build-agones-sdk-binary
483+
build-agones-sdk-image-arm64: $(ensure-build-image) build-agones-sdk-binary-linux-arm64
484484
docker buildx build --platform linux/arm64 --build-arg ARCH=arm64 $(agones_path)/cmd/sdk-server/ --tag=$(sidecar_linux_arm64_tag) $(DOCKER_BUILD_ARGS)
485485

486486
build-agones-sdk-image-windows: build-agones-sdk-binary

0 commit comments

Comments
 (0)