Skip to content

Commit 29bcc8f

Browse files
author
Robert Bailey
authored
Update our community membership guidelines to add a Releaser role. (agones-dev#2111)
1 parent 9bdf7a3 commit 29bcc8f

1 file changed

Lines changed: 41 additions & 5 deletions

File tree

‎docs/governance/community_membership.md‎

Lines changed: 41 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@ This document outlines the responsibilities of contributor roles in Agones.
44

55
This is based on the [Kubernetes Community Membership](https://github.com/kubernetes/community/blob/master/community-membership.md).
66

7-
There are currently only one role for this project, but that may grow in the future.
7+
There are currently two roles for this project, but that may grow in the future.
88

99
| Role | Responsibilities | Requirements | Defined by |
1010
| -----| ---------------- | ------------ | -------|
11-
| approver | review and approve contributions | sponsored by 2 reviewers. multiple contributions to the project. | Commit access to the Agones repository |
11+
| Releaser | Create Agones releases | Sponsored by 2 approvers | Commit access to the Agones repository |
12+
| Approver | Review and approve contributions | Sponsored by 2 approvers and multiple contributions to the project | Commit access to the Agones repository and [OWNERS] file approver entry |
13+
1214

1315
## New contributors
1416

@@ -24,15 +26,46 @@ policies, procedures, conventions, etc., and technical and/or writing ability.
2426
Role-specific expectations, responsibilities, and requirements are enumerated
2527
below.
2628

27-
## Approvers
29+
## Releaser
30+
31+
Releasers are engineers that are able to commit to the Agones repository with
32+
the express purpose of publishing Agones releases. They are **not** approvers
33+
and as such are not expected to perform code reviews or merge PRs. Using their
34+
commit privileges above and beyond creating releases is grounds for revoking
35+
commit access and being demoted from being a releaser.
36+
37+
**Defined by:** Commit access to the Agones repository.
38+
39+
### Requirements
40+
41+
- Enabled [two-factor authentication](https://help.github.com/articles/about-two-factor-authentication)
42+
on their GitHub account
43+
- Work at Google
44+
- This is due to some steps in the [release process](release_process.md) that require Google internal processes
45+
- Have read the [contributor guide](../../CONTRIBUTING.md)
46+
- Sponsored by 2 approvers. **Note the following requirements for sponsors**:
47+
- Unlike for the Approver role, sponsors should both be from Google
48+
- **[Open an issue](./templates/membership.md) against the Agones repo**
49+
- Ensure your sponsors are @mentioned on the issue
50+
- Label the issue with the `meta` tag
51+
- Complete every item on the checklist ([preview the current version of the template](./templates/membership.md))
52+
- There is no need to include any contributions to the Agones project
53+
- Have your sponsoring approvers reply confirmation of sponsorship: `+1`
54+
55+
### Responsibilities and privileges
56+
57+
- Responsible for creating Agones releases
58+
- Granted commit access to Agones repo
59+
60+
## Approver
2861

2962
Code approvers are able to both review and approve code contributions. While
3063
code review is focused on code quality and correctness, approval is focused on
3164
holistic acceptance of a contribution including: backwards / forwards
3265
compatibility, adhering to API and flag conventions, subtle performance and
3366
correctness issues, interactions with other parts of the system, etc.
3467

35-
**Defined by:** Commit access to the Agones repository.
68+
**Defined by:** Commit access to the Agones repository and [OWNERS] file approver entry.
3669

3770
**Note:** Acceptance of code contributions requires at least one approver.
3871

@@ -53,7 +86,7 @@ correctness issues, interactions with other parts of the system, etc.
5386
- Ensure your sponsors are @mentioned on the issue
5487
- Label the issue with the `meta` tag
5588
- Complete every item on the checklist ([preview the current version of the template](./templates/membership.md))
56-
- Make sure that the list of contributions included is representative of your work on the project.
89+
- Make sure that the list of contributions included is representative of your work on the project
5790
- Have your sponsoring approvers reply confirmation of sponsorship: `+1`
5891

5992
### Responsibilities and privileges
@@ -64,3 +97,6 @@ correctness issues, interactions with other parts of the system, etc.
6497
- Expected to be responsive to review requests in a timely manner
6598
- Assigned PRs to review related based on expertise
6699
- Granted commit access to Agones repo
100+
101+
[OWNERS]: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
102+

0 commit comments

Comments
 (0)