Skip to content

Commit 5a9ec13

Browse files
moacirmodarenzon
authored andcommitted
extracting function from duplicated code fixtures and removing fixture that use only ones
1 parent 3ce5976 commit 5a9ec13

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎pythonpro/analytics/tests/conftest.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ def pre_request():
1515
return request
1616

1717

18-
@pytest.fixture
19-
def mocked_request(pre_request):
18+
def _get_request_with_session_setted(pre_request):
2019
middleware = SessionMiddleware()
2120
middleware.process_request(pre_request)
2221
pre_request.session.save()
2322
return pre_request
2423

2524

2625
@pytest.fixture
27-
def mocked_request_2(pre_request):
28-
middleware = SessionMiddleware()
29-
middleware.process_request(pre_request)
30-
pre_request.session.save()
26+
def mocked_request(pre_request):
27+
return _get_request_with_session_setted(pre_request)
3128

32-
return pre_request
29+
30+
@pytest.fixture
31+
def mocked_request_2(pre_request):
32+
return _get_request_with_session_setted(pre_request)
3333

3434

3535
@pytest.fixture

‎pythonpro/analytics/tests/facade/test_get_or_create_session.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def test_should_create_an_usersession_on_database(request_created_in_fixture):
2626
@pytest.mark.django_db
2727
def test_should_not_assert_any_user_when_has_no_logged_in(
2828
request_created_in_fixture):
29-
assert not UserSession.objects.get().user
29+
assert UserSession.objects.get().user is None
3030

3131

3232
@pytest.mark.django_db

0 commit comments

Comments
 (0)