Skip to content

Commit 6f7c0ae

Browse files
committed
Issue python#28839: Optimize function_call()
function_call() now simply calls _PyFunction_FastCallDict(). _PyFunction_FastCallDict() is more efficient: it contains fast paths for the common case (optimized code object and no keyword argument).
1 parent b03beef commit 6f7c0ae

1 file changed

Lines changed: 6 additions & 47 deletions

File tree

‎Objects/funcobject.c‎

Lines changed: 6 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -563,55 +563,14 @@ func_traverse(PyFunctionObject *f, visitproc visit, void *arg)
563563
}
564564

565565
static PyObject *
566-
function_call(PyObject *func, PyObject *arg, PyObject *kw)
566+
function_call(PyObject *func, PyObject *args, PyObject *kwargs)
567567
{
568-
PyObject *result;
569-
PyObject *argdefs;
570-
PyObject *kwtuple = NULL;
571-
PyObject **d, **k;
572-
Py_ssize_t nk, nd;
573-
574-
argdefs = PyFunction_GET_DEFAULTS(func);
575-
if (argdefs != NULL && PyTuple_Check(argdefs)) {
576-
d = &PyTuple_GET_ITEM((PyTupleObject *)argdefs, 0);
577-
nd = PyTuple_GET_SIZE(argdefs);
578-
}
579-
else {
580-
d = NULL;
581-
nd = 0;
582-
}
583-
584-
if (kw != NULL && PyDict_Check(kw)) {
585-
Py_ssize_t pos, i;
586-
nk = PyDict_GET_SIZE(kw);
587-
kwtuple = PyTuple_New(2*nk);
588-
if (kwtuple == NULL)
589-
return NULL;
590-
k = &PyTuple_GET_ITEM(kwtuple, 0);
591-
pos = i = 0;
592-
while (PyDict_Next(kw, &pos, &k[i], &k[i+1])) {
593-
Py_INCREF(k[i]);
594-
Py_INCREF(k[i+1]);
595-
i += 2;
596-
}
597-
nk = i/2;
598-
}
599-
else {
600-
k = NULL;
601-
nk = 0;
602-
}
603-
604-
result = PyEval_EvalCodeEx(
605-
PyFunction_GET_CODE(func),
606-
PyFunction_GET_GLOBALS(func), (PyObject *)NULL,
607-
&PyTuple_GET_ITEM(arg, 0), PyTuple_GET_SIZE(arg),
608-
k, nk, d, nd,
609-
PyFunction_GET_KW_DEFAULTS(func),
610-
PyFunction_GET_CLOSURE(func));
611-
612-
Py_XDECREF(kwtuple);
568+
PyObject **stack;
569+
Py_ssize_t nargs;
613570

614-
return result;
571+
stack = &PyTuple_GET_ITEM(args, 0);
572+
nargs = PyTuple_GET_SIZE(args);
573+
return _PyFunction_FastCallDict(func, stack, nargs, kwargs);
615574
}
616575

617576
/* Bind a function to an object */

0 commit comments

Comments
 (0)