Skip to content

Commit 547397c

Browse files
committed
SF patch http://sourceforge.net/patch/?func=detailpatch&patch_id=103453&group_id=5470 PyMember_Set of T_CHAR always raises exception. Unfortunately, this is a use of a C API function that Python itself never makes, so there's no .py test I can check in to verify this stays fixed. But the fault in the code is obvious, and Dave Cole's patch just as obviously fixes it.
1 parent 40ead76 commit 547397c

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

‎Misc/ACKS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Tom Christiansen
7272
Vadim Chugunov
7373
Mike Clarkson
7474
Steve Clift
75+
Dave Cole
7576
Jeffery Collins
7677
Matt Conway
7778
Scott Cotton

‎Python/structmember.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ PyMember_Set(char *addr, struct memberlist *mlist, char *name, PyObject *v)
231231
PyErr_BadArgument();
232232
return -1;
233233
}
234+
break;
234235
default:
235236
PyErr_SetString(PyExc_SystemError,
236237
"bad memberlist type");

0 commit comments

Comments
 (0)