Skip to content

Commit 11060a4

Browse files
committed
python#13406: silence deprecation warnings in test_codecs.
1 parent 27c2a86 commit 11060a4

3 files changed

Lines changed: 17 additions & 10 deletions

File tree

‎Lib/test/test_codecs.py‎

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,17 +1025,22 @@ def test_bug1251300(self):
10251025
for internal, uni in ok:
10261026
if sys.byteorder == "little":
10271027
internal = bytes(reversed(internal))
1028-
self.assertEqual(uni, internal.decode("unicode_internal"))
1028+
with support.check_warnings():
1029+
self.assertEqual(uni, internal.decode("unicode_internal"))
10291030
for internal in not_ok:
10301031
if sys.byteorder == "little":
10311032
internal = bytes(reversed(internal))
1032-
self.assertRaises(UnicodeDecodeError, internal.decode,
1033-
"unicode_internal")
1033+
with support.check_warnings(('unicode_internal codecs has been '
1034+
'deprecated', DeprecationWarning)):
1035+
self.assertRaises(UnicodeDecodeError, internal.decode,
1036+
"unicode_internal")
10341037

10351038
@unittest.skipUnless(SIZEOF_WCHAR_T == 4, 'specific to 32-bit wchar_t')
10361039
def test_decode_error_attributes(self):
10371040
try:
1038-
b"\x00\x00\x00\x00\x00\x11\x11\x00".decode("unicode_internal")
1041+
with support.check_warnings(('unicode_internal codecs has been '
1042+
'deprecated', DeprecationWarning)):
1043+
b"\x00\x00\x00\x00\x00\x11\x11\x00".decode("unicode_internal")
10391044
except UnicodeDecodeError as ex:
10401045
self.assertEqual("unicode_internal", ex.encoding)
10411046
self.assertEqual(b"\x00\x00\x00\x00\x00\x11\x11\x00", ex.object)
@@ -1048,10 +1053,12 @@ def test_decode_error_attributes(self):
10481053
def test_decode_callback(self):
10491054
codecs.register_error("UnicodeInternalTest", codecs.ignore_errors)
10501055
decoder = codecs.getdecoder("unicode_internal")
1051-
ab = "ab".encode("unicode_internal").decode()
1052-
ignored = decoder(bytes("%s\x22\x22\x22\x22%s" % (ab[:4], ab[4:]),
1053-
"ascii"),
1054-
"UnicodeInternalTest")
1056+
with support.check_warnings(('unicode_internal codecs has been '
1057+
'deprecated', DeprecationWarning)):
1058+
ab = "ab".encode("unicode_internal").decode()
1059+
ignored = decoder(bytes("%s\x22\x22\x22\x22%s" % (ab[:4], ab[4:]),
1060+
"ascii"),
1061+
"UnicodeInternalTest")
10551062
self.assertEqual(("ab", 12), ignored)
10561063

10571064
def test_encode_length(self):

‎Modules/_codecsmodule.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ unicode_internal_encode(PyObject *self,
688688
return NULL;
689689

690690
if (PyErr_WarnEx(PyExc_DeprecationWarning,
691-
"unicode_internal codecs has been deprecated",
691+
"unicode_internal codec has been deprecated",
692692
1))
693693
return NULL;
694694

‎Objects/unicodeobject.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6235,7 +6235,7 @@ _PyUnicode_DecodeUnicodeInternal(const char *s,
62356235
PyObject *exc = NULL;
62366236

62376237
if (PyErr_WarnEx(PyExc_DeprecationWarning,
6238-
"unicode_internal codecs has been deprecated",
6238+
"unicode_internal codec has been deprecated",
62396239
1))
62406240
return NULL;
62416241

0 commit comments

Comments
 (0)