Skip to content

DictWrapper comparisons make no sense (and crashes) #253

Open

Description

@Avasam

You can't compare dicts using < and > . It seems this was naively adapted from python2's cmp 39b27b3 .
The same comparison happens in the Xlib.protocol.rq.Event class.

Given that direct dict comparisons are no longer supported in python3, I'd suggest either removing this broken code entirely, or reimplementing dict comparison.

Activity

  1. changed the title [-]`DictWrapper` comparisons make no sense[/-] [+]`DictWrapper` comparisons make no sense (and crashes)[/+] on Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions