Should I expect all tests to pass? #1519
|
Hi there, I forked the repo to make an MR, but I am getting failing tests when I run |
Replies: 1 comment 5 replies
|
Yes all tests should pass. If you submit your PR then the CI will run those tests. Without more detail I'm not sure why the tests are failing for you locally. |
|
Hm, ok so I forked the repo and ran pyenv virtualenv 3.9.4 gitlab
pip install --upgrade pip
pip install pre-commit
pre-commit install -t pre-commit -t commit-msg --install-hooks
pip install black
pip install tox
pip install -r requirements.txt
pip install -r requirements-docker.txt
pip install -r requirements-docs.txt
pip install -r requirements-lint.txt
pip install -r requirements-test.txt
tox -e py_func_v4I am running Python 3.9.4 on macOS Big Sur 11.4. Am I missing a step? Or is there more info I can provide you? |
|
So I run the tests inside an Ubuntu 20.04 VM and things work. Not sure if that is easy/possible to do on a Mac. I do this because I normally use Fedora and Fedora now uses Podman and I haven't spent the time to see if I can get the container working on Fedora yet. So easier to just run it in a VM using Ubuntu 20.04. The functional tests spin up a Docker container that runs an instance of Gitlab to do the testing. I have zero knowledge of Macs so I am unable to help you on any Mac specific issues 😢 |
|
the Is it possible the docker engine on your mac has too little resources? Could you increase the cpu/memory for the docker VM? Maybe get some help here https://docs.docker.com/docker-for-mac/ The docker functional tests are quite power-hungry. Our CI tests were not reliable with 4GB RAM VMs, but are stable with the current 8GB RAM runners (and more cores, but I forget the number). |
|
But as John said, if you can't get it to work just run the default set of |
|
Wow, great catch. Increasing the memory/cpu resources for Docker solved it. Thanks! |
Yes all tests should pass.
If you submit your PR then the CI will run those tests.
Without more detail I'm not sure why the tests are failing for you locally.