Repository navigation
phase_plot ODE function signature is not compatible with solve_ivp and StateSpace.dynamics #968
Description
Activity
Yes I agree,
phase_plothas the wrong parameter order, leftover from the previous convention. The docstring should also be updated to reference scipy's new integration scheme as well inscipy.integrate.solve_ivp.Please submit a pull request!
@murrayrm commented in #970 (comment) that he is rewriting parts of
phase_plot, so it might not be worthwhile for an external contributor to do a pull request changing the oldphase_plotcode right now.- linked a pull request that will close this issueReimplementation of 2D phase plots #980
on Mar 28, 2024
There seems to be some inconsistency with the ordering of parameters for ODE functions between
phase_plotandStateSpace.dynamics.phase_plotexpects a function with signature f(x, t), whereasStateSpace.dynamicsand other functions that are meant to be used withscipy.integrate.solve_ivpprovide a function with the signature f(t, x) (note that the order of arguments is different).It would be nice if the order of arguments was consistent, so you could pass functions compatible with
scipy.integrate.solve_ivpdirectly tophase_plot.